Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: support systems using the new cgroup v2 structure #3091

Merged
merged 1 commit into from
May 7, 2022

Conversation

Cytrian
Copy link

@Cytrian Cytrian commented May 5, 2022

With cgroup v2, the location of the pids.max file changed and so did the /proc/self/cgroup file

New /proc/self/cgroup file has only one line:

0::/user.slice/user-500.slice/session-14.scope

While the old file had a subsystem given for each line:

11:pids:/user.slice/user-500.slice/session-2.scope
10:blkio:/user.slice
9:net_cls,net_prio:/
8:perf_event:/
...

There is no directory per subsystem (e.g. /sys/fs/cgroup/pids) any more, all files are now in one directory.

Related issues

Fixes: #3085

@Madhu-1
Copy link
Collaborator

Madhu-1 commented May 5, 2022

@Cytrian Thanks for the PR can you please fix DCO and commitlint problem. Please refer DOC doc and commit message doc for help

Copy link
Collaborator

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM. waiting to fix DCO and commitlint

Copy link
Member

@nixpanic nixpanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the subject of the commit to have the right prefix, something like util: .... Lines in the commit message should not be longer than 80 characters.

We also require a Signed-off-by: line in the commit message (use git commit --amend -s).

If you make these changes, commitlint and DCO checks are expected to pass.

Thanks for your contribution, let us know if you need more assistance!

internal/util/pidlimit.go Outdated Show resolved Hide resolved
@Cytrian Cytrian changed the title Support systems using the new cgroup v2 structure util: support systems using the new cgroup v2 structure May 5, 2022
@Madhu-1 Madhu-1 requested a review from nixpanic May 5, 2022 10:24
@Madhu-1 Madhu-1 added the component/util Utility functions shared between CephFS and RBD label May 5, 2022
@nixpanic
Copy link
Member

nixpanic commented May 5, 2022

/retest ci/centos/mini-e2e-helm/k8s-1.22

@nixpanic
Copy link
Member

nixpanic commented May 5, 2022

/retest ci/centos/mini-e2e-helm/k8s-1.22

Spurious failure:

May  5 13:31:12.860: FAIL: backend images not matching kubernetes resource count,image count 24 kubernetes resource count 21

@humblec
Copy link
Collaborator

humblec commented May 6, 2022

@nixpanic iic, the requested changes are addressed in latest refresh of the patch.. may be remove the change requested?

@nixpanic
Copy link
Member

nixpanic commented May 7, 2022

/retest ci/centos/mini-e2e-helm/k8s-1.22

@nixpanic
Copy link
Member

nixpanic commented May 7, 2022

/retest ci/centos/mini-e2e-helm/k8s-1.22

Failed with:

May  5 17:10:11.482: backend images not matching kubernetes resource count,image count 23 kubernetes resource count 21

With cgroup v2, the location of the pids.max file changed and so did the
/proc/self/cgroup file

new /proc/self/cgroup file
`
0::/user.slice/user-500.slice/session-14.scope
`

old file:
`
11:pids:/user.slice/user-500.slice/session-2.scope
10:blkio:/user.slice
9:net_cls,net_prio:/
8:perf_event:/
...
`

There is no directory per subsystem (e.g. /sys/fs/cgroup/pids) any more, all
files are now in one directory.

fixes: ceph#3085

Signed-off-by: Marcus Röder <[email protected]>
@nixpanic nixpanic added the ci/retry/e2e Label to retry e2e retesting on approved PR's label May 7, 2022
@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/mini-e2e/k8s-1.22

@ceph-csi-bot
Copy link
Collaborator

@Cytrian "ci/centos/mini-e2e/k8s-1.22" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented May 7, 2022

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/mini-e2e-helm/k8s-1.22

@ceph-csi-bot
Copy link
Collaborator

@Cytrian "ci/centos/mini-e2e-helm/k8s-1.22" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented May 7, 2022

requeue

☑️ This pull request is already queued

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/mini-e2e-helm/k8s-1.21

@ceph-csi-bot
Copy link
Collaborator

@Cytrian "ci/centos/mini-e2e-helm/k8s-1.21" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/mini-e2e-helm/k8s-1.22

@ceph-csi-bot
Copy link
Collaborator

@Cytrian "ci/centos/mini-e2e-helm/k8s-1.22" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented May 7, 2022

requeue

☑️ This pull request is already queued

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/mini-e2e-helm/k8s-1.22

@ceph-csi-bot
Copy link
Collaborator

@Cytrian "ci/centos/mini-e2e-helm/k8s-1.22" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented May 7, 2022

requeue

☑️ This pull request is already queued

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/mini-e2e-helm/k8s-1.21

@ceph-csi-bot
Copy link
Collaborator

@Cytrian "ci/centos/mini-e2e-helm/k8s-1.21" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented May 7, 2022

requeue

☑️ This pull request is already queued

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/retry/e2e Label to retry e2e retesting on approved PR's component/util Utility functions shared between CephFS and RBD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setting pids.max failed with cgroups v2
6 participants