-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util: support systems using the new cgroup v2 structure #3091
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes LGTM. waiting to fix DCO and commitlint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the subject of the commit to have the right prefix, something like util: ...
. Lines in the commit message should not be longer than 80 characters.
We also require a Signed-off-by:
line in the commit message (use git commit --amend -s
).
If you make these changes, commitlint and DCO checks are expected to pass.
Thanks for your contribution, let us know if you need more assistance!
2e01290
to
e408dbf
Compare
e408dbf
to
ce3e9e6
Compare
/retest ci/centos/mini-e2e-helm/k8s-1.22 |
Spurious failure:
|
@nixpanic iic, the requested changes are addressed in latest refresh of the patch.. may be remove the |
/retest ci/centos/mini-e2e-helm/k8s-1.22 |
Failed with:
|
With cgroup v2, the location of the pids.max file changed and so did the /proc/self/cgroup file new /proc/self/cgroup file ` 0::/user.slice/user-500.slice/session-14.scope ` old file: ` 11:pids:/user.slice/user-500.slice/session-2.scope 10:blkio:/user.slice 9:net_cls,net_prio:/ 8:perf_event:/ ... ` There is no directory per subsystem (e.g. /sys/fs/cgroup/pids) any more, all files are now in one directory. fixes: ceph#3085 Signed-off-by: Marcus Röder <[email protected]>
ce3e9e6
to
4663da3
Compare
/retest ci/centos/mini-e2e/k8s-1.22 |
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
/retest ci/centos/mini-e2e-helm/k8s-1.22 |
@Mergifyio requeue |
☑️ This pull request is already queued |
/retest ci/centos/mini-e2e-helm/k8s-1.21 |
/retest ci/centos/mini-e2e-helm/k8s-1.22 |
@Mergifyio requeue |
☑️ This pull request is already queued |
/retest ci/centos/mini-e2e-helm/k8s-1.22 |
@Mergifyio requeue |
☑️ This pull request is already queued |
/retest ci/centos/mini-e2e-helm/k8s-1.21 |
@Mergifyio requeue |
☑️ This pull request is already queued |
With cgroup v2, the location of the
pids.max
file changed and so did the/proc/self/cgroup
fileNew /proc/self/cgroup file has only one line:
While the old file had a subsystem given for each line:
There is no directory per subsystem (e.g. /sys/fs/cgroup/pids) any more, all files are now in one directory.
Related issues
Fixes: #3085