rbd: enable expand operation for intree volumes

[humblec]

This commit enable the resize operation [1] for in-tree volumes.
new helper has been introduced here to aid the enablement or to
make it clean with existing code base.

[1] https://github.com/ceph/ceph-csi/blob/devel/docs/design/proposals/intree-migrate.md?plain=1#L66

Updates #2509

Signed-off-by: Humble Chirammal [email protected]

Additional Info:

• no unit test added for the helper newVolFromVolIDWithMigration() as it contains cr format as in other left out helpers.
• no e2e as it need support from sidecar..etc.
• I have tested this manually and the resize has worked as expected and also for other operations.

Here is the log:

I1222 06:34:26.791024 1000552 utils.go:177] ID: 26 Req-ID: mig_mons-b7f67366bb43f32e07d8a261a7840da9_image-773226a6-dbc3-47b5-b47c-bfa8d64b1e2e_7265706c696361706f6f6c GRPC call: /csi.v1./ExpandVolume
I1222 06:34:26.791314 1000552 utils.go:181] ID: 26 Req-ID: mig_mons-b7f67366bb43f32e07d8a261a7840da9_image-773226a6-dbc3-47b5-b47c-bfa8d64b1e2e_7265706c696361706f6f6c GRPC request: {"capacity_range":{"required_bytes":4294967296},....
I1222 06:34:26.828325 1000552 mount_linux.go:487] Attempting to determine if disk "/dev/rbd0" is formatted using blkid with args: ([-p -s TYPE -s PTTYPE -o export /dev/rbd0])
I1222 06:34:26.830157 1000552 mount_linux.go:490] Output: "DEVNAME=/dev/rbd0\nTYPE=ext4\n"
I1222 06:34:26.830187 1000552 resizefs_linux.go:56] ResizeFS.Resize - Expanding mounted volume /dev/rbd0
I1222 06:34:26.832030 1000552 resizefs_linux.go:71] Device /dev/rbd0 resized successfully
I1222 06:34:26.832140 1000552 utils.go:188] ID: 26 Req-ID: mig_mons-b7f67366bb43f32e07d8a261a7840da9_image-773226a6-dbc3-47b5-b47c-bfa8d64b1e2e_7265706c696361706f6f6c GRPC response: {}
...


[hchiramm@hchiramm ]$ mount |grep rbd
/dev/rbd0 on /var/lib/kubelet/plugins/kubernetes.io/csi/pv/pvc-c827c204-94e7-4ed9-87e9-fce212fe61a0/globalmount/mig_mons-b7f67366bb43f32e07d8a261a7840da9_image-773226a6-dbc3-47b5-b47c-bfa8d64b1e2e_7265706c696361706f6f6c type ext4 (rw,relatime,stripe=16,_netdev)
/dev/rbd0 on /var/lib/kubelet/pods/80dc68c4-049d-49cb-8933-abf64c35bb65/volumes/kubernetes.io~csi/pvc-c827c204-94e7-4ed9-87e9-fce212fe61a0/mount type ext4 (rw,relatime,stripe=16,_netdev)
[hchiramm@hchiramm ]$ kubectl exec -ti in-task-pv-pod -- df -kh|grep nginx
/dev/rbd0                                4.0G  4.0M  3.9G   1% /usr/share/nginx/html
[hchiramm@hchiramm ]$ 

[Madhu-1]

if not available Please add e2e changes for this one.

[humblec]

if not available Please add e2e changes for this one.

@Madhu-1 you mean in the tracker ?

[Madhu-1]

if not available Please add e2e changes for this one.

@Madhu-1 you mean in the tracker ?

as expand is getting adding in this PR it good to add E2E to make sure its working

[humblec]

if not available Please add e2e changes for this one.

@Madhu-1 you mean in the tracker ?

as expand is getting adding in this PR it good to add E2E to make sure its working

@Madhu-1 our current e2e for static volumes in general is not upto the mark. so adding an extension again on that at this stage is not really worth I believe. Once the sidecars are in place and when we revamp we can add or try to simulate the setups.

[Madhu-1]

small nit and suggested a nicer version for genVolFromVolIDWithMigration .

Pull request has been modified.

[humblec]

updated the nicer version too, the current github action failure is spurious one. conternarized-test pass locally.

[Madhu-1]

#2743 should fix CI

Pull request has been modified.