Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rebase: update the CSI Spec to v1.3.0 #1378

Merged
merged 1 commit into from
Sep 4, 2020
Merged

rebase: update the CSI Spec to v1.3.0 #1378

merged 1 commit into from
Sep 4, 2020

Conversation

humblec
Copy link
Collaborator

@humblec humblec commented Aug 13, 2020 •
edited
Loading

This spec add the extra capability to node and controller
volume to report volume condition of a pv..etc.

Refer # #1356

Signed-off-by: Humble Chirammal [email protected]

Madhu-1
Madhu-1 requested changes Aug 13, 2020
View reviewed changes
Copy link
Collaborator

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any code changes to implement any RPC call.

@nixpanic nixpanic added the rebase update the version of an external component label Aug 17, 2020
@nixpanic
Copy link
Member

This fails to build, please do minimal testing before posting rebase PRs (or mark them draft):

# github.com/ceph/ceph-csi/internal/cephfs
internal/cephfs/driver.go:155:61: cannot use fs.cs (type *ControllerServer) as type csi.ControllerServer in argument to server.Start:
	*ControllerServer does not implement csi.ControllerServer (missing ControllerGetVolume method)
# github.com/ceph/ceph-csi/internal/rbd
internal/rbd/driver.go:170:55: cannot use r.cs (type *ControllerServer) as type csi.ControllerServer in argument to s.Start:
	*ControllerServer does not implement csi.ControllerServer (missing ControllerGetVolume method)
make: *** [Makefile:129: cephcsi] Error 2

@nixpanic nixpanic marked this pull request as draft August 17, 2020 08:23
@ceph-csi-bot ceph-csi-bot force-pushed the update-spec branch 2 times, most recently from 05de501 to 5bc3a19 Compare August 17, 2020 09:49
@humblec
Copy link
Collaborator Author

humblec commented Aug 18, 2020

@nixpanic will be adding that part with this PR, thats why I pushed this PR separately. but i forgot to put it as draft or WIP..Any way this will be refreshed soon.

@humblec humblec changed the title build: update the CSI Spec to v1.3.0 [wip]build: update the CSI Spec to v1.3.0 Aug 18, 2020
@humblec humblec force-pushed the update-spec branch 3 times, most recently from 284fbb0 to b0775d1 Compare August 21, 2020 06:00
@humblec humblec changed the title [wip]build: update the CSI Spec to v1.3.0 build: update the CSI Spec to v1.3.0 Aug 24, 2020
@humblec
Copy link
Collaborator Author

humblec commented Aug 24, 2020

/retest all

@humblec humblec changed the title build: update the CSI Spec to v1.3.0 WIP build: update the CSI Spec to v1.3.0 Aug 24, 2020
@humblec humblec changed the title WIP build: update the CSI Spec to v1.3.0 build: update the CSI Spec to v1.3.0 Aug 25, 2020
nixpanic
nixpanic reviewed Aug 25, 2020
View reviewed changes
go.sum Show resolved Hide resolved
@humblec humblec marked this pull request as ready for review August 27, 2020 03:53
@humblec
Copy link
Collaborator Author

humblec commented Aug 27, 2020

@Madhu-1 @nixpanic ptal.

@humblec humblec changed the title build: update the CSI Spec to v1.3.0 rebase: update the CSI Spec to v1.3.0 Aug 27, 2020
@humblec humblec added this to the release-3.2.0 milestone Aug 27, 2020
@Madhu-1 Madhu-1 added the ready-to-merge This PR is ready to be merged and it doesn't need second review (backports only) label Sep 4, 2020
@humblec
rebase: update the CSI Spec to v1.3.0
1080818 
This spec add the extra capability to  node and controller
volume to report volume condition of a pv..etc.

Refer # ceph#1356

Signed-off-by: Humble Chirammal <[email protected]>
@mergify mergify bot merged commit edca318 into ceph:master Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nixpanic nixpanic nixpanic left review comments

@Madhu-1 Madhu-1 Madhu-1 approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR is ready to be merged and it doesn't need second review (backports only) rebase update the version of an external component
Projects
None yet
Milestone
release-3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@humblec @nixpanic @Madhu-1