rbd: unmap rbd image if the mounting fails #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug in current code where the devicePath is always empty and the rbd image unmap never happens if nodeplugin fails to mount the rbd image to the stagingpath. This is a fix to unmap the rbd image if some issue occurs after rbd image is mapped. Signed-off-by: Madhu Rajanna <[email protected]> (cherry picked from commit 2f7e510)
Updated E2E code to pass mountoptions when creating a storageclass. Signed-off-by: Madhu Rajanna <[email protected]> (cherry picked from commit 78cdf9d)
Added a test case to cover unmap of rbd image if the mounting fails. if we pass the invalid mount option the expectation is that mounting of rbd image to stagingpath fails. as the unmap happens it should not block the rbd pvc deletion saying rbd image is in-use. Signed-off-by: Madhu Rajanna <[email protected]> (cherry picked from commit 44da7ff)
5 tasks
humblec
approved these changes
Jun 5, 2020
|
Merging this one as CI is passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in the current code where the device path is always empty and the rbd image unmap never happens if node plugin fails to mount the rbd image to the staging path.
This is a fix to unmap the rbd image if some issue occurs after the rbd image is mapped.
Signed-off-by: Madhu Rajanna [email protected]
Backport of #1078