Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for rbd volume resizing #101

Closed
JrCs opened this issue Nov 22, 2018 · 15 comments
Closed

Add support for rbd volume resizing #101

JrCs opened this issue Nov 22, 2018 · 15 comments
Assignees
Labels
Priority-0 highest priority issue release-2.0.0 v2.0.0 release

Comments

@JrCs
Copy link

JrCs commented Nov 22, 2018

Can you add support for rbd volume resizing ?
See https://kubernetes.io/blog/2018/07/12/resizing-persistent-volumes-using-kubernetes/

@rootfs
Copy link
Member

rootfs commented Nov 26, 2018

that has to wait till kubernetes csi volume plugin supports expandable volume, something like this

@aibarbetta
Copy link

CSI seems to be supporting volume expansion now:
https://github.com/container-storage-interface/spec/blob/master/spec.md#controllerexpandvolume
https://github.com/container-storage-interface/spec/blob/master/spec.md#nodeexpandvolume
Is anything else needed on the k8s side in order to implement this feature?

@gman0
Copy link
Contributor

gman0 commented Dec 8, 2018

@abrden yes, something (external-provisioner) needs to implement the controller for expansion.

@rootfs
Copy link
Member

rootfs commented Jan 31, 2019

will revisit this request once external-resizer is ready and able to provide all the info (e.g. secret) to resize rbd/cephfs PVs.

@rootfs
Copy link
Member

rootfs commented Mar 7, 2019

now external-resize supports csi resize, we should pick it here.

cc @Madhu-1 @gman0 @humblec @j-griffith

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Mar 7, 2019

@rootfs does kube latest version supports volume expansion? , if yes i think we can take it, i was waiting for kube 1.14 release (i think it supports volume expansion) correct me if am wrong.

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Mar 7, 2019

/assign Madhu-1

@Madhu-1 Madhu-1 self-assigned this Mar 7, 2019
@rootfs
Copy link
Member

rootfs commented Mar 7, 2019

yes, k8s csi volume volume expansion is scheduled for k8s 1.14
kubernetes/kubernetes#74863

@humblec
Copy link
Collaborator

humblec commented Mar 8, 2019

@rootfs sure, we will take care of it.. @Madhu-1 lets sync up ..

@sandromodarelli
Copy link

any news about this issue? plans of release?

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Jul 22, 2019

as humble is working on this one. assigning to humble
#331

@Madhu-1 Madhu-1 assigned humblec and unassigned Madhu-1 Jul 22, 2019
@wavezhang
Copy link

Any progress on this?

@davi5e
Copy link

davi5e commented Aug 15, 2019

Besides any updates on the progress status, which would be the Kubernetes version this is being developed for? 1.14? 1.15?

@humblec
Copy link
Collaborator

humblec commented Aug 16, 2019

Besides any updates on the progress status, which would be the Kubernetes version this is being developed for? 1.14? 1.15?

@wavezhang @davi5e we have a prototype on resize here #331, but has not completed as there were various changes happening on rbd code with other bug fixes and enhancements. This feature was planned for #393 , however deferred to v2.0.0 which is planned at 3rd week of September.

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Jan 17, 2020

closing this one as this is implemented in #331

@Madhu-1 Madhu-1 closed this as completed Jan 17, 2020
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/ceph-csi that referenced this issue Jul 27, 2022
[DOWNSTREAM ONLY] ci: disable dependabot PR creation for Actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority-0 highest priority issue release-2.0.0 v2.0.0 release
Projects
None yet
Development

No branches or pull requests

9 participants