add name length validation for driver

Choosing an arbitary length which is 54 for the csi driver name and adding a validation to block CR creation if the name is having more chars. Signed-off-by: Madhu Rajanna <[email protected]>
ceph · Aug 6, 2024 · 1a7b9b5 · 1a7b9b5
1 parent e37c3f9
commit 1a7b9b5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/api/v1alpha1/driver_types.go b/api/v1alpha1/driver_types.go
@@ -371,6 +371,7 @@ type DriverStatus struct {
 //+kubebuilder:subresource:status
 
 // +kubebuilder:validation:XValidation:rule=self.metadata.name.matches('^(.+\\.)?(rbd|cephfs|nfs)?\\.csi\\.ceph\\.com$'),message=".metadata.name must match: '[<prefix>.](rbd|cephfs|nfs).csi.ceph.com'"
+// +kubebuilder:validation:XValidation:rule="self.metadata.name.size() <= 54",message=".metadata.name must be no more than 54 characters"
 // Driver is the Schema for the drivers API
 type Driver struct {
 	metav1.TypeMeta   `json:",inline"`

diff --git a/config/crd/bases/csi.ceph.io_drivers.yaml b/config/crd/bases/csi.ceph.io_drivers.yaml
@@ -6788,6 +6788,8 @@ spec:
         x-kubernetes-validations:
         - message: '.metadata.name must match: ''[<prefix>.](rbd|cephfs|nfs).csi.ceph.com'''
           rule: self.metadata.name.matches('^(.+\\.)?(rbd|cephfs|nfs)?\\.csi\\.ceph\\.com$')
+        - message: .metadata.name must be no more than 54 characters
+          rule: self.metadata.name.size() <= 54
     served: true
     storage: true
     subresources: