ceph: fix dentry leak in splice_dentry()

In any case, d_splice_alias() does not drop reference of original dentry. Signed-off-by: "Yan, Zheng" <[email protected]> Reviewed-by: Jeff Layton <[email protected]> Signed-off-by: Ilya Dryomov <[email protected]>
ceph · Jun 26, 2018 · 8b8f53a · 8b8f53a
1 parent 7daf201
commit 8b8f53a
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/fs/ceph/inode.c b/fs/ceph/inode.c
@@ -1135,6 +1135,7 @@ static struct dentry *splice_dentry(struct dentry *dn, struct inode *in)
 	if (IS_ERR(realdn)) {
 		pr_err("splice_dentry error %ld %p inode %p ino %llx.%llx\n",
 		       PTR_ERR(realdn), dn, in, ceph_vinop(in));
+		dput(dn);
 		dn = realdn; /* note realdn contains the error */
 		goto out;
 	} else if (realdn) {