Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules: Add _info modules #7624

Merged
merged 1 commit into from
Dec 5, 2024
Merged

modules: Add _info modules #7624

merged 1 commit into from
Dec 5, 2024

Conversation

asm0deuz
Copy link
Collaborator

Validate modules test fails with:

Argument state includes get, list or info as a choice. Functionality should be in an _info or (if further conditions apply) _facts module.

on modules ceph_crush_rule and ceph_key

With Ansible 2.8 and onwards best practice requires that modules gathering info to be put in a separate module named _info[1]

[1]https://docs.ansible.com/ansible/latest/dev_guide/developing_modules_general.html#creating-an-info-or-a-facts-module

@asm0deuz asm0deuz force-pushed the add_info_modules branch 3 times, most recently from 4ac55e4 to 980fa05 Compare November 21, 2024 09:02
@asm0deuz asm0deuz force-pushed the add_info_modules branch 3 times, most recently from 6baf7b1 to dac6077 Compare December 4, 2024 15:44
@asm0deuz asm0deuz changed the title modules: Add _info modules [skip ci] modules: Add _info modules Dec 4, 2024
@asm0deuz asm0deuz force-pushed the add_info_modules branch 4 times, most recently from 7d9e036 to 7b87558 Compare December 5, 2024 10:38
@asm0deuz asm0deuz changed the title [skip ci] modules: Add _info modules modules: Add _info modules Dec 5, 2024
Validate modules test fails with:

Argument state includes get, list or info as a choice.
Functionality should be in an _info or (if further conditions apply) _facts module.

on modules ceph_crush_rule and ceph_key

With Ansible 2.8 and onwards best practice requires that modules
gathering info to be put in a separate module named _info[1]

[1]https://docs.ansible.com/ansible/latest/dev_guide/developing_modules_general.html#creating-an-info-or-a-facts-module

Signed-off-by: Teoman ONAY <[email protected]>
@guits guits merged commit a1f65bb into ceph:main Dec 5, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants