-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ceph-config: introduce dedicated cluster config flow #7475
Conversation
91266f7
to
9fea46f
Compare
2914acf
to
0778b81
Compare
#ceph_cluster_conf: | ||
# global: | ||
# public_network: "{{ public_network | default(omit) }}" | ||
# cluster_network: "{{ cluster_network | default(omit) }}" | ||
# osd_pool_default_crush_rule: "{{ osd_pool_default_crush_rule }}" | ||
# ms_bind_ipv6: "{{ (ip_version == 'ipv6') | string }}" | ||
# ms_bind_ipv4: "{{ (ip_version == 'ipv4') | string }}" | ||
# osd_crush_chooseleaf_type: "{{ '0' if common_single_host_mode | default(false) else omit }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#ceph_cluster_conf: | |
# global: | |
# public_network: "{{ public_network | default(omit) }}" | |
# cluster_network: "{{ cluster_network | default(omit) }}" | |
# osd_pool_default_crush_rule: "{{ osd_pool_default_crush_rule }}" | |
# ms_bind_ipv6: "{{ (ip_version == 'ipv6') | string }}" | |
# ms_bind_ipv4: "{{ (ip_version == 'ipv4') | string }}" | |
# osd_crush_chooseleaf_type: "{{ '0' if common_single_host_mode | default(false) else omit }}" | |
# ceph_cluster_conf: | |
# global: | |
# public_network: "{{ public_network | default(omit) }}" | |
# cluster_network: "{{ cluster_network | default(omit) }}" | |
# osd_pool_default_crush_rule: "{{ osd_pool_default_crush_rule }}" | |
# ms_bind_ipv6: "{{ (ip_version == 'ipv6') | string }}" | |
# ms_bind_ipv4: "{{ (ip_version == 'ipv4') | string }}" | |
# osd_crush_chooseleaf_type: "{{ '0' if common_single_host_mode | default(false) else omit }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is generated by the script - would it work by changing it? I guess CI would complain?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to modify the script then 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it was good to have comments for vars with no space so the real comments for vars could be distinguished from those. What do you think?
e67925c
to
1ac8ee5
Compare
kenkins test centos-container-all_in_one |
jenkins test centos-non_container-all_in_one |
jenkins test centos-container-all_in_one |
2 similar comments
jenkins test centos-container-all_in_one |
jenkins test centos-container-all_in_one |
71e7935
to
83a8b16
Compare
jenkins test centos-non_container-switch_to_containers |
jenkins test centos-non_container-collocation |
1 similar comment
jenkins test centos-non_container-collocation |
jenkins test centos-container-all_in_one |
jenkins test centos-non_container-all_in_one |
1 similar comment
jenkins test centos-non_container-all_in_one |
Signed-off-by: Seena Fallah <[email protected]>
Signed-off-by: Seena Fallah <[email protected]>
Signed-off-by: Seena Fallah <[email protected]>
jenkins test centos-container-lvm_batch |
jenkins test centos-non_container-all_in_one |
jenkins test centos-non_container-collocation |
This is needed for new instances are the restart might trigger before the deployment Signed-off-by: Seena Fallah <[email protected]>
systemctl restart ceph-radosgw@rgw.${HOST_NAME}.${INSTANCES_NAME[i]} | ||
|
||
# Check if systemd unit exists | ||
# This is needed for new instances are the restart might trigger before the deployment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# This is needed for new instances are the restart might trigger before the deployment | |
# This is needed for new instances as the restart might trigger before the deployment |
No description provided.