Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph-config: introduce dedicated cluster config flow #7475

Merged
merged 4 commits into from
Feb 16, 2024

Conversation

clwluvw
Copy link
Member

@clwluvw clwluvw commented Feb 14, 2024

No description provided.

@clwluvw clwluvw marked this pull request as draft February 14, 2024 14:29
@clwluvw clwluvw force-pushed the ceph-config branch 2 times, most recently from 91266f7 to 9fea46f Compare February 14, 2024 14:32
@clwluvw clwluvw force-pushed the ceph-config branch 3 times, most recently from 2914acf to 0778b81 Compare February 14, 2024 21:20
site-container.yml.sample Outdated Show resolved Hide resolved
Comment on lines +277 to +269
#ceph_cluster_conf:
# global:
# public_network: "{{ public_network | default(omit) }}"
# cluster_network: "{{ cluster_network | default(omit) }}"
# osd_pool_default_crush_rule: "{{ osd_pool_default_crush_rule }}"
# ms_bind_ipv6: "{{ (ip_version == 'ipv6') | string }}"
# ms_bind_ipv4: "{{ (ip_version == 'ipv4') | string }}"
# osd_crush_chooseleaf_type: "{{ '0' if common_single_host_mode | default(false) else omit }}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#ceph_cluster_conf:
# global:
# public_network: "{{ public_network | default(omit) }}"
# cluster_network: "{{ cluster_network | default(omit) }}"
# osd_pool_default_crush_rule: "{{ osd_pool_default_crush_rule }}"
# ms_bind_ipv6: "{{ (ip_version == 'ipv6') | string }}"
# ms_bind_ipv4: "{{ (ip_version == 'ipv4') | string }}"
# osd_crush_chooseleaf_type: "{{ '0' if common_single_host_mode | default(false) else omit }}"
# ceph_cluster_conf:
# global:
# public_network: "{{ public_network | default(omit) }}"
# cluster_network: "{{ cluster_network | default(omit) }}"
# osd_pool_default_crush_rule: "{{ osd_pool_default_crush_rule }}"
# ms_bind_ipv6: "{{ (ip_version == 'ipv6') | string }}"
# ms_bind_ipv4: "{{ (ip_version == 'ipv4') | string }}"
# osd_crush_chooseleaf_type: "{{ '0' if common_single_host_mode | default(false) else omit }}"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is generated by the script - would it work by changing it? I guess CI would complain?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to modify the script then 🙂

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it was good to have comments for vars with no space so the real comments for vars could be distinguished from those. What do you think?

group_vars/rhcs.yml.sample Outdated Show resolved Hide resolved
site.yml.sample Outdated Show resolved Hide resolved
@clwluvw clwluvw force-pushed the ceph-config branch 2 times, most recently from e67925c to 1ac8ee5 Compare February 14, 2024 22:21
@clwluvw
Copy link
Member Author

clwluvw commented Feb 15, 2024

kenkins test centos-container-all_in_one

@clwluvw
Copy link
Member Author

clwluvw commented Feb 15, 2024

jenkins test centos-non_container-all_in_one

@clwluvw
Copy link
Member Author

clwluvw commented Feb 15, 2024

jenkins test centos-container-all_in_one

2 similar comments
@clwluvw
Copy link
Member Author

clwluvw commented Feb 15, 2024

jenkins test centos-container-all_in_one

@clwluvw
Copy link
Member Author

clwluvw commented Feb 15, 2024

jenkins test centos-container-all_in_one

@clwluvw clwluvw marked this pull request as ready for review February 15, 2024 18:36
@clwluvw clwluvw force-pushed the ceph-config branch 2 times, most recently from 71e7935 to 83a8b16 Compare February 15, 2024 23:46
@guits
Copy link
Collaborator

guits commented Feb 16, 2024

jenkins test centos-non_container-switch_to_containers

@guits
Copy link
Collaborator

guits commented Feb 16, 2024

jenkins test centos-non_container-collocation

1 similar comment
@guits
Copy link
Collaborator

guits commented Feb 16, 2024

jenkins test centos-non_container-collocation

@guits
Copy link
Collaborator

guits commented Feb 16, 2024

jenkins test centos-container-all_in_one

@guits
Copy link
Collaborator

guits commented Feb 16, 2024

jenkins test centos-non_container-all_in_one

1 similar comment
@clwluvw
Copy link
Member Author

clwluvw commented Feb 16, 2024

jenkins test centos-non_container-all_in_one

@clwluvw
Copy link
Member Author

clwluvw commented Feb 16, 2024

jenkins test centos-container-lvm_batch

@clwluvw
Copy link
Member Author

clwluvw commented Feb 16, 2024

jenkins test centos-non_container-all_in_one

@clwluvw
Copy link
Member Author

clwluvw commented Feb 16, 2024

jenkins test centos-non_container-collocation

This is needed for new instances are the restart might trigger before the deployment

Signed-off-by: Seena Fallah <[email protected]>
systemctl restart ceph-radosgw@rgw.${HOST_NAME}.${INSTANCES_NAME[i]}

# Check if systemd unit exists
# This is needed for new instances are the restart might trigger before the deployment
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# This is needed for new instances are the restart might trigger before the deployment
# This is needed for new instances as the restart might trigger before the deployment

@guits guits merged commit 7142321 into ceph:main Feb 16, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants