Do not pass NoneType as argument to ceph_crush_rule (backport #7466) #7469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
|
I'm not actually sure that failures I see are related with the backport itself... |
Nope it looks CI env related. Should be fixed any time soon |
|
jenkins test centos-non_container-update |
With ansible-core 2.15 it is not possible to pass argument of unexpected type, as otherwise module will fail with: `'None' is not a string and conversion is not allowed` With that we want to only get all existing crush rules, so we can simply supply an empty string as a name argument, which would satisfy requirements and have same behaviour for previous ansible versions. Alternative approach would be to stop making `name` as a required argument to the module and use empty string as default value when info state is used. Signed-off-by: Dmitriy Rabotyagov <[email protected]> (cherry picked from commit b610297)
asm0deuz
force-pushed
the
mergify/bp/stable-7.0/pr-7466
branch
from
314da6b to
71fc540
Compare
|
jenkins test centos-container-all_daemons |
guits
force-pushed
the
stable-7.0
branch
3 times, most recently
from
91f2ae8 to
7a9f871
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #7466 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com