Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: isolate ansible collections #7264

Merged
merged 2 commits into from
Aug 3, 2022
Merged

tests: isolate ansible collections #7264

merged 2 commits into from
Aug 3, 2022

Conversation

guits
Copy link
Collaborator

@guits guits commented Jul 29, 2022

When Ansible collections are installed, they should be isolated.
Otherwise, they will be shared in any scheduled job.
This might cause issues when running different branch versions for instance.

Signed-off-by: Guillaume Abrioux [email protected]

@guits guits changed the title [skip ci] tests: isolate ansible collections tests: isolate ansible collections Jul 29, 2022
@guits guits changed the title tests: isolate ansible collections [skip ci] tests: isolate ansible collections Jul 29, 2022
@guits guits force-pushed the fix-collections-install-ci branch from 2e91cdc to 331d0ef Compare July 29, 2022 09:26
@guits guits changed the title [skip ci] tests: isolate ansible collections tests: isolate ansible collections Jul 29, 2022
@guits guits changed the title tests: isolate ansible collections [skip ci] tests: isolate ansible collections Jul 29, 2022
@guits guits changed the title [skip ci] tests: isolate ansible collections tests: isolate ansible collections Jul 29, 2022
@guits guits changed the title tests: isolate ansible collections [skip ci] tests: isolate ansible collections Jul 29, 2022
@guits guits force-pushed the fix-collections-install-ci branch from 331d0ef to 008ad15 Compare July 29, 2022 09:34
@guits guits changed the title [skip ci] tests: isolate ansible collections tests: isolate ansible collections Jul 29, 2022
@guits guits changed the title tests: isolate ansible collections [skip ci] tests: isolate ansible collections Jul 29, 2022
@guits guits force-pushed the fix-collections-install-ci branch from 008ad15 to ba388cf Compare July 29, 2022 09:36
@guits guits changed the title [skip ci] tests: isolate ansible collections tests: isolate ansible collections Jul 29, 2022
@guits guits changed the title tests: isolate ansible collections [skip ci] tests: isolate ansible collections Jul 29, 2022
@guits guits force-pushed the fix-collections-install-ci branch from ba388cf to 962d301 Compare July 29, 2022 09:48
@guits guits changed the title [skip ci] tests: isolate ansible collections tests: isolate ansible collections Jul 29, 2022
@guits guits changed the title tests: isolate ansible collections [skip ci] tests: isolate ansible collections Jul 29, 2022
@guits guits changed the title [skip ci] tests: isolate ansible collections tests: isolate ansible collections Jul 29, 2022
@guits guits force-pushed the fix-collections-install-ci branch from 962d301 to 13f9c1a Compare July 29, 2022 10:44
@guits guits requested a review from asm0deuz July 29, 2022 10:45
@guits guits force-pushed the fix-collections-install-ci branch from 13f9c1a to c519f84 Compare July 29, 2022 11:25
When Ansible collections are installed, they should be isolated.
Otherwise, they will be shared in any scheduled job.
This might cause issues when running different branch versions for instance.
This also replace `ANSIBLE_CALLBACK_WHITELIST` with `ANSIBLE_CALLBACK_ENABLED` as it's
going to be deprecated in Ansible 2.15.

Signed-off-by: Guillaume Abrioux <[email protected]>
@guits guits force-pushed the fix-collections-install-ci branch from c519f84 to b28d7a7 Compare August 3, 2022 04:51
There's no service to stop/mask when the node being upgraded is
a 'primary node' only (1 way replication).

Signed-off-by: Guillaume Abrioux <[email protected]>
@guits guits merged commit 82e0ae7 into main Aug 3, 2022
@guits guits deleted the fix-collections-install-ci branch August 3, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant