Skip to content

Commit

Permalink
ephadm-adopt: Alertmanager placement count missing
Browse files Browse the repository at this point in the history
Regression from #7576. Alertmanager placement count was missing
after migration to ceph_orch_apply module

Signed-off-by: Teoman ONAY <[email protected]>
(cherry picked from commit 31be495)
  • Loading branch information
asm0deuz committed Oct 14, 2024
1 parent 5e7ceff commit f8bd922
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions infrastructure-playbooks/cephadm-adopt.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1517,8 +1517,8 @@
environment:
CEPHADM_IMAGE: '{{ ceph_docker_registry }}/{{ ceph_docker_image }}:{{ ceph_docker_image_tag }}'

- name: with dashboard enabled
when: dashboard_enabled | bool
- name: With dashboard enabled
when: dashboard_enabled | bool and groups.get(monitoring_group_name, []) | length > 0
block:
- name: Update the placement of alertmanager hosts
ceph_orch_apply:
Expand All @@ -1528,6 +1528,7 @@
service_id: "{{ ansible_facts['hostname'] }}"
placement:
label: "{{ monitoring_group_name }}"
count: "{{ groups.get(monitoring_group_name, []) | length }}"
{% if grafana_server_addr is defined %}
networks:
- {{ grafana_server_addr }}
Expand All @@ -1542,10 +1543,6 @@
environment:
CEPHADM_IMAGE: '{{ ceph_docker_registry }}/{{ ceph_docker_image }}:{{ ceph_docker_image_tag }}'

<<<<<<< HEAD
- name: update the placement of prometheus hosts
command: "{{ cephadm_cmd }} shell -k /etc/ceph/{{ cluster }}.client.admin.keyring --fsid {{ fsid }} -- ceph orch apply prometheus --placement='{{ groups.get(monitoring_group_name, []) | length }} label:{{ monitoring_group_name }}'"
=======
- name: Update the placement of prometheus hosts
ceph_orch_apply:
fsid: "{{ fsid }}"
Expand All @@ -1559,7 +1556,6 @@
spec:
port: {{ prometheus_port }}
{% endif %}
>>>>>>> b41b7bf86 (cephadm-adopt: custom prometheus port lost after adoption)
changed_when: false
environment:
CEPHADM_IMAGE: '{{ ceph_docker_registry }}/{{ ceph_docker_image }}:{{ ceph_docker_image_tag }}'
Expand Down

0 comments on commit f8bd922

Please sign in to comment.