ceph-mds: fix the handler

Moving the mds_name fact in the common role so the MDS can properly be restarted. Signed-off-by: Sébastien Han <[email protected]> (cherry picked from commit b397135)
ceph · May 10, 2016 · 3f67741 · 3f67741
1 parent 35048d5
commit 3f67741
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 9 deletions.
diff --git a/group_vars/all.sample b/group_vars/all.sample
@@ -303,6 +303,7 @@ dummy:
 ## MDS options
 #
 #mds_use_fqdn: false # if set to true, the MDS name used will be the fqdn in the ceph.conf
+#mds_name: "{{ ansible_hostname }}"
 
 ## Rados Gateway options
 #
@@ -380,3 +381,4 @@ dummy:
 # by ceph.conf.j2 template. so it should always be defined
 #mon_containerized_deployment_with_kv: false
 
+
diff --git a/group_vars/common-coreoss.sample b/group_vars/common-coreoss.sample
@@ -14,4 +14,3 @@ dummy:
 #pypy_binary_directory: /opt/bin
 #pip_url: https://bootstrap.pypa.io/get-pip.py
 #local_temp_directory: /tmp
-
diff --git a/roles/ceph-common/tasks/facts.yml b/roles/ceph-common/tasks/facts.yml
@@ -61,3 +61,12 @@
 
 - set_fact:
     is_kraken={{ ceph_version | version_compare('11.0.0', '>=')  and ceph_version | version_compare('12.0.0', '<') }}
+
+- set_fact:
+    mds_name: "{{ ansible_hostname }}"
+  when: not mds_use_fqdn
+
+- set_fact:
+    mds_name: "{{ ansible_fqdn }}"
+  when: mds_use_fqdn
+
diff --git a/roles/ceph-mds/tasks/pre_requisite.yml b/roles/ceph-mds/tasks/pre_requisite.yml
@@ -1,12 +1,4 @@
 ---
-- set_fact:
-    mds_name: "{{ ansible_hostname }}"
-  when: not mds_use_fqdn
-
-- set_fact:
-    mds_name: "{{ ansible_fqdn }}"
-  when: mds_use_fqdn
-
 - name: create bootstrap-mds directory
   file:
     path: /var/lib/ceph/bootstrap-mds/
Original file line number	Diff line number	Diff line change
Expand Up		@@ -14,4 +14,3 @@ dummy:
		#pypy_binary_directory: /opt/bin
		#pip_url: https://bootstrap.pypa.io/get-pip.py
		#local_temp_directory: /tmp