Skip to content

Commit

Permalink
bump ansible-core to <2.16
Browse files Browse the repository at this point in the history
- Remove python3 shebangs
- command module warn parameter is deprecated since 2.11 and removed
  from 2.14

Signed-off-by: Teoman ONAY <[email protected]>
  • Loading branch information
asm0deuz committed Jan 16, 2024
1 parent 7806e51 commit 087d3a3
Show file tree
Hide file tree
Showing 8 changed files with 5 additions and 21 deletions.
8 changes: 0 additions & 8 deletions infrastructure-playbooks/purge-cluster.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1000,13 +1000,9 @@

- name: remove package dependencies on redhat
command: yum -y autoremove
args:
warn: no

- name: remove package dependencies on redhat again
command: yum -y autoremove
args:
warn: no
when:
ansible_facts['pkg_mgr'] == "yum"

Expand All @@ -1019,13 +1015,9 @@

- name: remove package dependencies on redhat
command: dnf -y autoremove
args:
warn: no

- name: remove package dependencies on redhat again
command: dnf -y autoremove
args:
warn: no
when:
ansible_facts['pkg_mgr'] == "dnf"
when:
Expand Down
2 changes: 0 additions & 2 deletions library/ceph_pool.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
#!/usr/bin/python3

# Copyright 2020, Red Hat, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# These are Python requirements needed to run ceph-ansible main
ansible-core>=2.12,<2.13
ansible-core<2.16
netaddr
six
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,5 @@
# Remove yum caches so yum doesn't get confused if we are reinstalling a different ceph version
- name: purge yum cache

Check failure on line 19 in roles/ceph-common/tasks/installs/configure_redhat_repository_installation.yml

View workflow job for this annotation

GitHub Actions / build

[E303] yum used in place of yum module
command: yum clean all
args:
warn: no
changed_when: false
when: ansible_facts['pkg_mgr'] == 'yum'
2 changes: 0 additions & 2 deletions roles/ceph-infra/tasks/configure_firewall.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
---
- name: check firewalld installation on redhat or SUSE/openSUSE

Check failure on line 2 in roles/ceph-infra/tasks/configure_firewall.yml

View workflow job for this annotation

GitHub Actions / build

[E303] rpm used in place of yum or rpm_key module
command: rpm -q firewalld
args:
warn: no
register: firewalld_pkg_query
ignore_errors: true
check_mode: no
Expand Down
2 changes: 0 additions & 2 deletions roles/ceph-rgw/tasks/openstack-keystone.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@

- name: create nss entries for keystone certificates
shell: "{{ item }}"
args:
warn: no
changed_when: false
with_items:
- "openssl x509 -in /etc/keystone/ssl/certs/ca.pem -pubkey | certutil -d {{ radosgw_nss_db_path }} -A -n ca -t 'TCu,Cu,Tuw'"
Expand Down
4 changes: 2 additions & 2 deletions roles/ceph-validate/tasks/check_system.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@

- name: fail on unsupported ansible version
fail:
msg: "Ansible version must be 2.12!"
when: ansible_version.minor|int != 12
msg: "Ansible version must be 2.15!"
when: ansible_version.minor|int != 15

- name: fail on unsupported system
fail:
Expand Down
4 changes: 2 additions & 2 deletions tests/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
pytest-testinfra
pytest-xdist
pytest
ansible-core>=2.12,<2.13,!=2.9.10
Jinja2>=2.10
ansible-core<2.16
Jinja2
netaddr
mock
jmespath
Expand Down

0 comments on commit 087d3a3

Please sign in to comment.