fix flatten_dictionary to work with ceph infernalis #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since at least ceph infernalis the dumped structure looks like this excerpt:
u'mds_epoch': {u'nick': u'', u'type': 2, u'description': u'Current epoch of MDS map'},
w/o this fix you get e.g. a path of [(['cluster','mds_epoch','description'],'Current epoch of MDS map')]
instead of the assumed [(['cluster','mds_epoch','type'],2)]
|
@strima Thank you! I have fixed this here https://github.com/python-diamond/Diamond/pull/321/files#diff-733cf31c9f55d206bd14fa56ed0f985bR335 as well. I intend to merge that work into this repo and build new packages for download.ceph.com. |
|
@strima Also our approaches to solving this issue seem different. I'm doing a whitelist of schema fields to report stats on. See my comment on the upstream PR. You seem to be blacklisting schema fields that are present today. It's my opinion that the white-list approach is better because it will handle future additions to the schema without modifications. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since at least ceph infernalis the dumped structure looks like this excerpt:
u'mds_epoch': {u'nick': u'', u'type': 2, u'description': u'Current epoch of MDS map'},
w/o this fix you get e.g. a path of [(['cluster','mds_epoch','description'],'Current epoch of MDS map')]
instead of the assumed [(['cluster','mds_epoch','type'],2)]
this was (at least for me) the reason why dashboard didn't show any iops/usage values. these values never made it to the graphite instance and therefore i didn't have any ceph.cluster. values in graphite which of course led to not showing them ;)