Replace subkey with go port #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 17, 2020 14:42
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
=======================================
Coverage 58.11% 58.12%
=======================================
Files 93 93
Lines 3259 3245 -14
=======================================
- Hits 1894 1886 -8
+ Misses 987 985 -2
+ Partials 378 374 -4
Continue to review full report at Codecov.
|
added 3 commits
January 8, 2021 14:57
…t into mmuftic/replace-subkey-with-go-port
vedhavyas
approved these changes
Jan 16, 2021
|
@vedhavyas Great 🥳 When could I expect this to be released, as I would like to move away from our custom fork and use your client? |
mikiquantum
approved these changes
Jan 19, 2021
|
@MakMuftic @vedhavyas Merging now, will release as well. |
vgeddes
added a commit
to Snowfork/go-substrate-rpc-client
that referenced
this pull request
Feb 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced calling
subkeywith go-subkey port as I mentioned in #112closes #112