Release v0.11.3 #1886

wischli · 2024-06-24T10:01:00Z

Description

Extension of #1882

Changes dev session duration from 6 hours to 2 minutes (context)
Updates weights
Adds CheckMetadataHash signed extension feat: CheckMetadataHash extension #1865

Checklist:

I have added Rust doc comments to structs, enums, traits and functions
I have made corresponding changes to the documentation
I have performed a self-review of my code
I have added tests that prove my fix is effective or that my feature works

lemunozm · 2024-06-24T18:50:10Z

pallets/pool-system/src/tranches.rs

+			const TOTAL_ASSETS: Balance = DEBT_RES
+				+ RESERVE_RES + DEBT_NONRES_1
+				+ RESERVE_NONRES_1
+				+ DEBT_NONRES_2 + RESERVE_NONRES_2;


Before you get crazy with this and the rustfmt. Upgrade your current nightly rust tooling, because they have made a major version in the rustfmt without upgrading the version number or waiting to the next rust version 🥲

Thanks! That's exactly what I did an hour ago. I suppose you were there at some point as well. We should pinpoint the nightly version in the toolchain toml if possible or else the setup script.

lemunozm · 2024-06-24T18:52:59Z

runtime/centrifuge/src/weights/pallet_oracle_collection.rs

-		Weight::from_parts(130_825_000, 0)
+		//  Estimated: `16920 + m * (6039 ±0) + n * (100600 ±3_323)`
+		// Minimum execution time: 127_009_000 picoseconds.
+		Weight::from_parts(128_011_000, 0)


Similar-smaller weights with the wasm executor? I would expect more weight 🤔

It appears to me that weights weren't overall affected by the client changes. Roughly 5-10% variance is normal between different benchmarks without code changes AFAICT.

Ok, I would expect the benchmarking to take longer in wasm, because is slower than native. But maybe somehow the benchmarking is done in the same environment before and now

lemunozm

Just one comment, if it's ok, then I approve it

lemunozm · 2024-06-25T10:28:16Z

runtime/development/src/migrations.rs

@@ -26,7 +26,7 @@ const IDENTITY_MIGRATION_KEY_LIMIT: u64 = 1000;

 /// The migration set for Development & Demo.
 /// It includes all the migrations that have to be applied on that chain.
-pub type UpgradeDevelopment1100 = (


Should be this migration removed since they were done in RU 1100?

Yeah we could have removed them. Too late now anyways that the RU was performed on Dev and Demo. I will clean up all migrations after cutting the release.

codecov · 2024-06-25T14:55:10Z

Codecov Report

Attention: Patch coverage is 0% with 45 lines in your changes missing coverage. Please review.

Project coverage is 47.68%. Comparing base (e5c8926) to head (dd9ff86).

Files	Patch %	Lines
node/src/command.rs	0.00%	27 Missing ⚠️
node/src/service/evm.rs	0.00%	5 Missing ⚠️
pallets/oracle-feed/src/lib.rs	0.00%	5 Missing ⚠️
node/src/service.rs	0.00%	4 Missing ⚠️
runtime/development/src/lib.rs	0.00%	2 Missing ⚠️
runtime/altair/src/lib.rs	0.00%	1 Missing ⚠️
runtime/centrifuge/src/lib.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1886      +/-   ##
==========================================
+ Coverage   47.66%   47.68%   +0.02%     
==========================================
  Files         171      171              
  Lines       13232    13219      -13     
==========================================
- Hits         6307     6304       -3     
+ Misses       6925     6915      -10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* set dependency versions * upgrade libs/* * upgrade pallet-anchors * upgrade pallet-fees * upgrade pallet-bridge * migrate simple pallets * migrate pallet-order-book * migrated collator-allowlist & swaps * upgrade rewards * upgraded pallet-mux * upgrade transfer-allowlist * fix hold reason in restricted tokens * simplify set_balance removing the holding part * upgrade restricted-xtokens * upgrade some pallets * upgrade pallet-ethereum-transaction * upgrade pallet-loans * upgrade pool-system * upgrade pool-fees * upgrade pool-registry * upgrade liquidity-pools stuffs * avoid duplicated polkadot-sdk repos * minor fixes * upgraded runtime-common * CfgLocation to RestrictedTransferLocation * restricted tokens with NativeIndex for native fungibles * rename dependency * upgraded development-runtime * fix partially benchmarks * fix benchmarks * overpass xcmp-queue integrity tests * minor coments * upgrade altair & centrifuge * remove some benchmarking pallets that are not needed * fix runtime upgrades * upgrade integration-test proc * upgrade integration-tests framework * upgraded all tests except liquidity pools * 99% upgraded liquidity-pools tests * fix lookup * cargo fmt * taplo fmt * using nightly cargo in CI * restore set_balance as it was * allow nightly support in CI * use restricted_tokens again to fetch from investement portfolio * Install rust-src for docs * fix tests * remove unused restricted tokens * fix block rewards * fix WrongWitness for some tests in IT * fix liquidity-pools * minor fixes * fix clippy * remove unneeded tests * feat: Update client to Polkadot v1.7.2 (#1844) * wip: update client * chore: update crate versions * chore: update anchor rpc api * chore: remove rewards, pools rpc * chore: compile with development runtime * fix: client for all runtimes * fix: build spec * feat: update relay docker images * fix: apply deprecation of export genesis state to scripts * fmt: taplo * refactor: use xcm v4 sugar * fix: revert tmp change in local para run * refactor: simplify xcm v4 locations in chain spec * cargo fmt * fix clippy * feat: Polkadot v1.7.2 migrations (#1849) * feat: add hold reason migration * feat: centrifuge migrations * feat: altair migrations * feat: dev + demo migrations * fix: clippy * fix: build * fmt: fix using nightly * last William iteration review * increase passed blocks * use rococo instead of polkadot-test-runtime * fix tests * remove line * dirty fix to fix Hrmp test issue * use default weights for treasury * remove getrandom unused dep * upgrade to last polkadot-sdk version * feat: `CheckMetadataHash` extension * fix it (#1866) * fmt: taplo * refactor: signed ext order * fix: signed ext order for ITs * IT: more support for router tests (#1885) * move routers to its own module * remove outdated markers * for all runtimes * remove previous tests * minor fixes * v0.11.2 rc * panic if event is not found in the expected blocks (#1880) * fix: ci * remove generic module (#1887) * revert check metadata hash disable * fix: disable metadata hash check for integration tests --------- Co-authored-by: lemunozm <[email protected]>

lemunozm

Reapproving!

mustermeiszer

LGTM! Thanks

fix: adapt passthrough router fix: docs and hash chore: rm unused test Release v0.11.3 (#1886) * Switch to full wasm execution * feat: use correct encoded size. * fix: lint * refactor: reduce dev session duration from 6h to 2min * chore: update centrifuge weights * chore: update dev weights * chore: update altair weights * chore: update frame_system weights * fmt * fix: re-enable frame_system benches * chore: bump spec version * fmt: revert using latest nightly * v0.11.3-rc1: revert checkmetadata ext * feat: `CheckMetadataHash` extension (#1865) * set dependency versions * upgrade libs/* * upgrade pallet-anchors * upgrade pallet-fees * upgrade pallet-bridge * migrate simple pallets * migrate pallet-order-book * migrated collator-allowlist & swaps * upgrade rewards * upgraded pallet-mux * upgrade transfer-allowlist * fix hold reason in restricted tokens * simplify set_balance removing the holding part * upgrade restricted-xtokens * upgrade some pallets * upgrade pallet-ethereum-transaction * upgrade pallet-loans * upgrade pool-system * upgrade pool-fees * upgrade pool-registry * upgrade liquidity-pools stuffs * avoid duplicated polkadot-sdk repos * minor fixes * upgraded runtime-common * CfgLocation to RestrictedTransferLocation * restricted tokens with NativeIndex for native fungibles * rename dependency * upgraded development-runtime * fix partially benchmarks * fix benchmarks * overpass xcmp-queue integrity tests * minor coments * upgrade altair & centrifuge * remove some benchmarking pallets that are not needed * fix runtime upgrades * upgrade integration-test proc * upgrade integration-tests framework * upgraded all tests except liquidity pools * 99% upgraded liquidity-pools tests * fix lookup * cargo fmt * taplo fmt * using nightly cargo in CI * restore set_balance as it was * allow nightly support in CI * use restricted_tokens again to fetch from investement portfolio * Install rust-src for docs * fix tests * remove unused restricted tokens * fix block rewards * fix WrongWitness for some tests in IT * fix liquidity-pools * minor fixes * fix clippy * remove unneeded tests * feat: Update client to Polkadot v1.7.2 (#1844) * wip: update client * chore: update crate versions * chore: update anchor rpc api * chore: remove rewards, pools rpc * chore: compile with development runtime * fix: client for all runtimes * fix: build spec * feat: update relay docker images * fix: apply deprecation of export genesis state to scripts * fmt: taplo * refactor: use xcm v4 sugar * fix: revert tmp change in local para run * refactor: simplify xcm v4 locations in chain spec * cargo fmt * fix clippy * feat: Polkadot v1.7.2 migrations (#1849) * feat: add hold reason migration * feat: centrifuge migrations * feat: altair migrations * feat: dev + demo migrations * fix: clippy * fix: build * fmt: fix using nightly * last William iteration review * increase passed blocks * use rococo instead of polkadot-test-runtime * fix tests * remove line * dirty fix to fix Hrmp test issue * use default weights for treasury * remove getrandom unused dep * upgrade to last polkadot-sdk version * feat: `CheckMetadataHash` extension * fix it (#1866) * fmt: taplo * refactor: signed ext order * fix: signed ext order for ITs * IT: more support for router tests (#1885) * move routers to its own module * remove outdated markers * for all runtimes * remove previous tests * minor fixes * v0.11.2 rc * panic if event is not found in the expected blocks (#1880) * fix: ci * remove generic module (#1887) * revert check metadata hash disable * fix: disable metadata hash check for integration tests --------- Co-authored-by: lemunozm <[email protected]> --------- Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Frederik Gartenmeister <[email protected]> Co-authored-by: lemunozm <[email protected]> Refactor: Decoupling routers from gateway (#1891) * decoupling routers from gateway. Use Vec<u8> * gateway adapted * fix imports * move test msg to cfg-traits * fix imports feat: Open Gov for Development and Altair Runtimes (#1828) * chore: add OpenGov pallets to root toml * feat: add OpenGov tracks to runtime common * feat: add technical committee migration tc: fix clippy * refactor: move origins from primitives to common common: fix typo common: fix test after HalfOfCouncil refactor * feat: add OpenGov to Development fix: complete Development OpenGov development: finalize opengov development: add proxy calls development: overwrite missing origins dev: fix treasury spender dev: remove crowdloan pallets dev: taplo fmt * feat: add OpenGov to Altair fix: complete Altair OpenGov fix: add missing technical fellowship weights Altair altair: finalize opengov altair: rename track tests altair: gather imports altair: remove crowdloan pallets altair: taplo fmt * feat: add OpenGov to Centrifuge chain fix: centrifuge toml chore: minor centrifuge chain improvements refactor: Centrifuge OpenGov centrifuge: finalize opengov centrifuge: fix cargo tml cfg: fix clippy test * Revert "feat: add OpenGov to Centrifuge chain" This reverts commit 4d78c10. * fix: clippy * tests: fix CouncilCollective import path * fix: technical committee migrations * altair: configure tc migration (incomplete) * dev: configure tc migration * chore: cleanup altair dep diff * chore: remove unused getrandom crate from runtimes * chore: add missing Altair TC members * refactor: move to_ppm and to_percent to utils * Merge remote-tracking branch 'origin/main' into feat/open-gov-2 * fix: issues after rebasing * fmt * fix: imports * feat: v0.12.0 for altair RU Altair: release v0.12.0 (#1896) * fix: altair chain spec * chore: update gov2 weights * chore: update dev OpenGov weights * fix: weight declaration Fix RustDocs deployment & codecov patch checks (#1870) * Fix deploy docs * Make patch checks also informational (not fail) LP Message with custom data format for serialization/deserialization (#1889) * test compiling * fix Domain serialization * fix issues * some reorganizations * using bincode 2 with non-std support * use custom trait * tests passing for lp * remove ENCODED_MSG constant * fix runtimes compilation * cargo fmt & taplo fmt * cargo clippy * minor change * add custom serializer passing all tests * no_std support * minor renames * cargo fmt * cargo clippy * minor comment change * cargo fmt extra Succeed when patch codecov fails (#1900) Liquidity pools: Add UTs to for `update_token_price()` (#1890) * add token price UTs * update IT * fix tests compilation remove some unused code investment-related (#1902) Release v0.13.0 (#1898) * chore: update deps to enable metadata hash check * chore: update srtool + add on-chain-release-build opts * chore: bump spec versions + cleanup migrations * fmt: taplo * ci: fix srtool fmt * ci: apply proper CLI * attempt2 to enable on-chain-release-build * change srtool build for chevdor/strool-actions action * desperate attempts to get it working * override workdir * Try to set permissions wide open before running docker * add RUST_BACKTRACE * revert to our GHA manual process & add enhancements * fix package name * Output information about srtool * Revert "desperate attempts to get it working" This reverts commit a882fd9. * fix: some scripts * fix bad colon on echo command * Fix missing colon and remove docker publish release * upload wasm to release * fix issue with gchr tags * more semicolon issues * unique name for delete untagged * fix delete_untagged * move delete_untagged under workflows * move delete untagged to manual runs * review bash syntax for wasm build * recover cache and limit sanity check build time --------- Co-authored-by: Guillermo Perez <[email protected]> cargo update (#1904) add uts (#1905) IT: Support `#ignore = reason` for `test_runtimes` macro (#1908) * support #ignore = reason for test_runtimes macro * fix clippy ci: disable checks for drafts (#1913) LP: Unitary testing for add_currency (#1912) * port add-currency tests into uts * remove LiquidityPoolsWrappedToken struct * remove unused code * fix compilation issues * fix clippy * fix clippy feat: adatpt to latest version LP: Unitary testing for all pending extrinsics (#1916) * allow and disallow currency tests * schedule_upgrade cancel_upgrade and update_tranche_token_metadata Feat: Adapt proxy settings (#1922) * feat: adapt proxy settings * fix: match pattern Small CI improvements (#1924) LP: Unitary testing for inbound messages (#1927) * tests inbound messages * some cleanings * some adjustements fix: array size fix: clippy + fmt fix: update blake hash fix: compilation Refactor: Transform `TrancheCurrency` type in a tuple (#1926) * remove TrancheCurrency type * fix benchmarks * fix clippy fix: std import KeccakHasher

bkchr and others added 6 commits June 21, 2024 12:54

Switch to full wasm execution

b32c5c1

feat: use correct encoded size.

3057bdf

fix: lint

7333779

Merge branch 'main' into fix/release-v0.11.0/v2

a2adb47

Merge remote-tracking branch 'origin/main' into release-v0.11.1

b45bc40

refactor: reduce dev session duration from 6h to 2min

019c8c1

wischli added the I9-release A specific release. label Jun 24, 2024

wischli self-assigned this Jun 24, 2024

mustermeiszer mentioned this pull request Jun 24, 2024

Fix/release v0.11.0/v2 #1882

Closed

4 tasks

wischli added 6 commits June 24, 2024 15:18

chore: update centrifuge weights

ca755ea

chore: update dev weights

5d93f9b

chore: update altair weights

248cb08

chore: update frame_system weights

b13622f

fmt

cc0c746

fix: re-enable frame_system benches

afffd15

wischli had a problem deploying to production June 24, 2024 14:26 — with GitHub Actions Error

wischli had a problem deploying to production June 24, 2024 14:44 — with GitHub Actions Error

wischli had a problem deploying to production June 24, 2024 14:46 — with GitHub Actions Error

chore: bump spec version

cee1882

wischli temporarily deployed to production June 24, 2024 14:48 — with GitHub Actions Inactive

fmt: revert using latest nightly

8b8b86b

lemunozm reviewed Jun 24, 2024

View reviewed changes

Merge branch 'main' into release-v0.11.1

faa2858

wischli marked this pull request as ready for review June 25, 2024 09:53

wischli requested a review from lemunozm June 25, 2024 09:53

lemunozm reviewed Jun 25, 2024

View reviewed changes

Merge branch 'main' into release-v0.11.1

2b5f708

lemunozm previously approved these changes Jun 25, 2024

View reviewed changes

v0.11.3-rc1: revert checkmetadata ext

e7b54c9

wischli dismissed lemunozm’s stale review via e7b54c9 June 26, 2024 19:01

wischli had a problem deploying to production June 26, 2024 19:01 — with GitHub Actions Failure

wischli had a problem deploying to production June 26, 2024 19:01 — with GitHub Actions Error

wischli requested review from mustermeiszer, cdamian and hieronx as code owners June 27, 2024 15:14

Merge remote-tracking branch 'origin/main' into release-v0.11.1

dd9ff86

wischli temporarily deployed to production June 27, 2024 15:20 — with GitHub Actions Inactive

wischli changed the title ~~Release v0.11.1~~ Release v0.11.3 Jun 27, 2024

wischli requested a review from lemunozm June 27, 2024 15:24

lemunozm approved these changes Jun 28, 2024

View reviewed changes

wischli enabled auto-merge (squash) June 28, 2024 08:42

mustermeiszer approved these changes Jun 28, 2024

View reviewed changes

wischli merged commit eb38d05 into main Jun 28, 2024
16 of 17 checks passed

wischli deleted the release-v0.11.1 branch June 28, 2024 08:55

wischli restored the release-v0.11.1 branch July 4, 2024 20:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release v0.11.3 #1886

Release v0.11.3 #1886

wischli commented Jun 24, 2024 •

edited

Loading

lemunozm Jun 24, 2024 •

edited

Loading

wischli Jun 24, 2024

lemunozm Jun 24, 2024

wischli Jun 24, 2024

lemunozm Jun 24, 2024

lemunozm left a comment

lemunozm Jun 25, 2024

wischli Jun 25, 2024

codecov bot commented Jun 25, 2024 •

edited

Loading

lemunozm left a comment

mustermeiszer left a comment

Release v0.11.3 #1886

Release v0.11.3 #1886

Conversation

wischli commented Jun 24, 2024 • edited Loading

Description

Checklist:

lemunozm Jun 24, 2024 • edited Loading

Choose a reason for hiding this comment

wischli Jun 24, 2024

Choose a reason for hiding this comment

lemunozm Jun 24, 2024

Choose a reason for hiding this comment

wischli Jun 24, 2024

Choose a reason for hiding this comment

lemunozm Jun 24, 2024

Choose a reason for hiding this comment

lemunozm left a comment

Choose a reason for hiding this comment

lemunozm Jun 25, 2024

Choose a reason for hiding this comment

wischli Jun 25, 2024

Choose a reason for hiding this comment

codecov bot commented Jun 25, 2024 • edited Loading

Codecov Report

lemunozm left a comment

Choose a reason for hiding this comment

mustermeiszer left a comment

Choose a reason for hiding this comment

wischli commented Jun 24, 2024 •

edited

Loading

lemunozm Jun 24, 2024 •

edited

Loading

codecov bot commented Jun 25, 2024 •

edited

Loading