-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing try runtime install #1883
base: main
Are you sure you want to change the base?
Conversation
/try-runtime |
/try-runtime |
1 similar comment
/try-runtime |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1883 +/- ##
=======================================
Coverage 46.69% 46.69%
=======================================
Files 179 179
Lines 13071 13071
=======================================
Hits 6103 6103
Misses 6968 6968 ☔ View full report in Codecov by Sentry. |
There was an error where
If that's expected we could merge this PR but otherwise it might be interesting to try and fix it |
Yes, it is expected: paritytech/polkadot-sdk#4603 |
BTW, why we're not checking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would love if we used the newest version of try-runtime CLI.
Unfortunately, this error is expected on Centrifuge and Altair, until we upgrade both Chains to SDK v1.7.2. More context can be found in #1849 or this conversation. |
Co-authored-by: William Freudenberger <[email protected]>
This should be ready to merge, demo seems to be running as expected since the following error is due to the runtime being the same?
Should we add the |
Sure sounds good! |
Description
This PR tries to fix try-runtime build since it was reporting
try-runtime command not found
Downloading the blob before executing try-runtime seems to fix it, inspired by https://github.com/paritytech/try-runtime-gha/blob/main/action.yml
Note: the
try-runtime
command still fails but is now running as expected