Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin websocket refactoring #83

Merged
merged 16 commits into from
Mar 24, 2016
Merged

Admin websocket refactoring #83

merged 16 commits into from
Mar 24, 2016

Conversation

FZambia
Copy link
Member

@FZambia FZambia commented Mar 22, 2016

For #73

@FZambia
Copy link
Member Author

FZambia commented Mar 22, 2016

To summarize what have been done here:

New option admin - it enables admin socket which is now off by default. For backwards compatibility web option also enables admin socket automatically (because web uses this socket).

So to start Centrifugo with admin socket enabled:

centrifugo --config=config.json --admin

But this will also enable admin socket handler (and additionally will serve web interface):

centrifugo --config=config.json --web

Also --insecure_web is now --insecure_admin but old option still supported to not break things.

web_password and web_secret are now admin_password and admin_secret but old option names supported as well.

Also web interface can now use only AuthHandler and admin websocket for everything - so I removed InfoHandler and ActionHandler. Refactored web interface frontend at moment sits in its own branch in web repo - will embed it in the end.

Also the work here is not complete because I think it will be good to add message queue for admin connection (like client's message queue) - but this does not affect old functionality so can be done later.

@banks
Copy link
Member

banks commented Mar 22, 2016

Didn't look in great detail but overall it seems good.

@FZambia FZambia merged commit 633967d into master Mar 24, 2016
@FZambia FZambia deleted the admin_websocket branch March 28, 2016 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants