http.ResponseController to set write timeout in SSE and HTTP-streaming handlers #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FZambia
changed the title
FZambia
changed the title
j178
pushed a commit
to j178/centrifuge
that referenced
this pull request
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently servers which are using streaming connections need to avoid setting write timeouts. With Go 1.20 it's possible to use http.ResponseController for flexible control over write timeout in the scope of request handling. In this PR we are adding support for it. Centrifuge still need to support Go 1.19 - that's why we have build tags here. As soon as Go 1.21 out it will be possible to remove the boilerplate.
Follow golang/go#16100 and golang/go#54136 for more details about http.ResponseController
Also some related updates in examples. And stick with Go 1.20 in examples.