Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

quickstart/python: use Zipkin exporter for tracing tutorials #356

Merged
merged 1 commit into from
Sep 24, 2018

Conversation

PikBot
Copy link
Contributor

@PikBot PikBot commented Sep 24, 2018

quickstart/python: use Zipkin exporter for tracing tutorials

Replace Stackdriver Trace exporter with Zipkin exporter in tracing quickstart
since Zipkin is easy to setup, free, open sourced.

Updates #343
Updates #353

@PikBot
Copy link
Contributor Author

PikBot commented Sep 24, 2018

@odeke-em please have a look !

@songy23 songy23 requested a review from odeke-em September 24, 2018 15:39
@odeke-em
Copy link
Member

Thank you @PikBot, this is great!

Just one minor nit. Could you please make your commit message:

quickstart/python: use Zipkin exporter for tracing tutorials

Replace Stackdriver Trace exporter with Zipkin exporter in tracing quickstart
since Zipkin is easy to setup, free, open sourced.

Updates #343
Updates #353

Fixes # will close an issue Updates # will update it :)

Replace Stackdriver Trace exporter with Zipkin exporter in tracing quickstart
since Zipkin is easy to setup, free, open sourced.

Updates census-instrumentation#343
Updates census-instrumentation#353
@PikBot
Copy link
Contributor Author

PikBot commented Sep 24, 2018

Updated @odeke-em !

Copy link
Member

@odeke-em odeke-em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you @PikBot! LGTM!

@odeke-em odeke-em merged commit d02058a into census-instrumentation:master Sep 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants