Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added isort support #797

Merged

Conversation

dineshkrishnareddy
Copy link
Contributor

Added isort support for repo #478

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@dineshkrishnareddy dineshkrishnareddy changed the title added isort support (fix https://github.com/census-instrumentation/opencensus-python/issues/478) added isort support Oct 4, 2019
@dineshkrishnareddy
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

docs/trace/usage.rst Outdated Show resolved Hide resolved
@lzchen
Copy link
Contributor

lzchen commented Oct 4, 2019

@dineshkrishnareddy
Thanks so much for contributing! The PR looks good and thanks for following what we have in OpenTelemetry. I would recommend pulling the latest master branch as there are some files that are missing such as [#793]. I left a comment. Also please fix your CI :).

@dineshkrishnareddy
Copy link
Contributor Author

@lzchen thanks, fixed CI. Please have a look

@lzchen lzchen merged commit f4d8ec3 into census-instrumentation:master Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants