Metrics: Add Value, Point and Summary #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
reviewed
Oct 5, 2018
opencensus/metrics/export/summary.py
Outdated
|
|
||
|
|
||
| class Summary(object): | ||
| """Implementation of the Distribution as a summary of observations. |
opencensus/metrics/export/summary.py
Outdated
| :param sum_data: the sum of the population values. | ||
|
|
||
| :type snapshot: Snapshot | ||
| :param snapshot: the bucket boundaries of a histogram. |
There was a problem hiding this comment.
snapshot is not histogram buckets.
opencensus/metrics/export/summary.py
Outdated
|
|
||
| @property | ||
| def snapshot(self): | ||
| """Returns the bucket boundaries of a histogram.""" |
opencensus/metrics/export/summary.py
Outdated
| def __init__(self, percentile, value): | ||
|
|
||
| if not 0 < percentile <= 100.0: | ||
| raise ValueError("percentile must be in the interval (0.0, 100.0)") |
There was a problem hiding this comment.
nit: s/(0.0, 100.0)/(0.0, 100.0]
c24t
reviewed
Oct 5, 2018
opencensus/metrics/export/summary.py
Outdated
| def __init__(self, percentile, value): | ||
|
|
||
| if not 0 < percentile <= 100.0: | ||
| raise ValueError("percentile must be in the interval (0.0, 100.0)") |
There was a problem hiding this comment.
Might want this to be (0.0, 100.0] to match the check (and the spec).
opencensus/metrics/export/summary.py
Outdated
|
|
||
| self._percentile = percentile | ||
|
|
||
| if value <= 0: |
opencensus/metrics/export/summary.py
Outdated
| def check_count_and_sum(count, sum_data): | ||
| if not (count is None or count >= 0): | ||
| raise ValueError('count must be non-negative') | ||
| elif not (sum_data is None or sum_data >= 0): |
There was a problem hiding this comment.
Nit, but you might just want if here so if the caller does handle the first error (unlikely, I know) you still check the other cases.
opencensus/metrics/export/summary.py
Outdated
| raise ValueError('sum_data must be non-negative') | ||
| elif count is not None and count == 0: | ||
| if not (sum_data is None or sum_data == 0): | ||
| raise ValueError('sum_data must be 0 if count is 0') |
There was a problem hiding this comment.
But it's ok to have a null count and non-null sum_data?
opencensus/metrics/export/summary.py
Outdated
| raise ValueError('count must be non-negative') | ||
| elif not (sum_data is None or sum_data >= 0): | ||
| raise ValueError('sum_data must be non-negative') | ||
| elif count is not None and count == 0: |
| def setUp(self): | ||
| self.double_value = value_module.Value.double_value(55.5) | ||
| self.long_value = value_module.Value.long_value(9876543210) | ||
| self.timestamp = datetime.utcnow().isoformat() + 'Z' |
There was a problem hiding this comment.
Might want to freeze this to avoid flaky tests if something does go wrong parsing a particular time.
opencensus/metrics/export/value.py
Outdated
| return ValueSummary(value) | ||
|
|
||
| @property | ||
| def get_value(self): |
There was a problem hiding this comment.
Not value? I'd expect get_x to be a method, x to be a property.
| self.assertIsNotNone(summary.snapshot) | ||
| self.assertIsInstance(summary.snapshot, summary_module.Snapshot) | ||
|
|
||
| def test_constructor_with_Negative_count(self): |
This was referenced Oct 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #335