Set SpanKind in extensions #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@songy23 please review |
songy23
reviewed
Aug 22, 2018
There was a problem hiding this comment.
LGTM overall. I don't have much context on framework integration in Python, so defer to @liyanhui1228 for approval.
eduardoemery
pushed a commit
to CESARBR/opencensus-python
that referenced
this pull request
Aug 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Span kind is optional, but highly recommended flag that denotes the type of span: Server or Client.
It's the only reliable way to determine whether it is an incoming or outgoing request. Some backends like Azure ApplicationInsights rely on such into to build the UX.