Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document 'google-cloud-trace' and BackgroundThreadTransport #262

Merged
merged 3 commits into from
Aug 24, 2018
Merged

Document 'google-cloud-trace' and BackgroundThreadTransport #262

merged 3 commits into from
Aug 24, 2018

Conversation

stewartreichling
Copy link
Contributor

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@stewartreichling
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

README.rst Outdated
pip install google-cloud-trace
pipenv install google-cloud-trace

.. _pip: https://pip.pypa.io
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pip and pipenv target are defined at the beginning, please fix this in order to make the CI green.

nox > python setup.py check --restructuredtext --strict
running check
warning: check: Duplicate explicit target name: "pip".

warning: check: Duplicate explicit target name: "pipenv".

error: Please correct your package.

@liyanhui1228 liyanhui1228 merged commit 2bc3745 into census-instrumentation:master Aug 24, 2018
@odeke-em
Copy link
Member

Thank you @stewblr for the fix and @liyanhui1228 for the review and merge!

@stewblr in the future, in your commit message, please add the phrase Fixes #<issueNumber> so that Github can auto-close the issue, for example this one could be

README: update Stackdriver*Exporter pip instal and need for BackgroundThreadTransport 

Fixes #260

and that would have auto-closed this issue after the PR had been merged :)

@stewartreichling
Copy link
Contributor Author

Will do, thanks for the tip!

eduardoemery pushed a commit to CESARBR/opencensus-python that referenced this pull request Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants