-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document 'google-cloud-trace' and BackgroundThreadTransport #262
Document 'google-cloud-trace' and BackgroundThreadTransport #262
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
README.rst
Outdated
pip install google-cloud-trace | ||
pipenv install google-cloud-trace | ||
|
||
.. _pip: https://pip.pypa.io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pip
and pipenv
target are defined at the beginning, please fix this in order to make the CI green.
nox > python setup.py check --restructuredtext --strict
running check
warning: check: Duplicate explicit target name: "pip".
warning: check: Duplicate explicit target name: "pipenv".
error: Please correct your package.
Thank you @stewblr for the fix and @liyanhui1228 for the review and merge! @stewblr in the future, in your commit message, please add the phrase README: update Stackdriver*Exporter pip instal and need for BackgroundThreadTransport
Fixes #260 and that would have auto-closed this issue after the PR had been merged :) |
Will do, thanks for the tip! |
No description provided.