Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in updating aggregation map. #253

Merged
merged 4 commits into from
Aug 23, 2018
Merged

Fix bug in updating aggregation map. #253

merged 4 commits into from
Aug 23, 2018

Conversation

songy23
Copy link
Contributor

@songy23 songy23 commented Aug 9, 2018 •
edited
Loading

Fixes #231.

  1. Remove _tag_map and get_tag_map from view_data. view_data.record() should always use the given context.
  2. The key for ViewData.tag_value_aggregation_map should be tuples of TagValues, rather than individual TagValue.
  3. When creating a new entry in ViewData.tag_value_aggregation_map, use copy.deepcopy() to create a blank AggregationData.
  4. Use tag_value_aggregation_data_map instead of tag_value_aggregation_map.

@songy23 songy23 added the stats label Aug 9, 2018
@songy23 songy23 requested a review from liyanhui1228 August 9, 2018 21:39
@songy23 songy23 merged commit a7e7573 into census-instrumentation:master Aug 23, 2018
@songy23
Copy link
Contributor Author

songy23 commented Aug 23, 2018

Thanks!

@songy23 songy23 deleted the fix-stats branch August 23, 2018 22:13
eduardoemery pushed a commit to CESARBR/opencensus-python that referenced this pull request Aug 30, 2018
@songy23 @eduardoemery
Fix bug in updating aggregation map. (census-instrumentation#253)
ad877b0 
* Fix bug in updating aggregation map.

* Update unit tests.

* Use tag_value_aggregation_data_map instead of tag_value_aggregation_map.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liyanhui1228 liyanhui1228 liyanhui1228 approved these changes

Assignees
No one assigned
Labels
cla: yes stats
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@songy23 @liyanhui1228 @googlebot