This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Add ZipkinReporter #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmatsuo
approved these changes
Aug 10, 2017
| use Prophecy\Argument; | ||
|
|
||
| /** | ||
| * @group trace |
There was a problem hiding this comment.
Is @group trace still relevant?
There was a problem hiding this comment.
For now, they are all in the trace group. OpenCensus does eventually plan to have other metrics and stats reporting in the future.
|
Great stuff and thanks! PS if it makes it any easier, very latest zipkin supports a simpler json format. I know that probably for existing sites you may need to retain the v1 format until folks upgrade. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
ZipkinReporterwhich using built-in http streaming capabilities to report to a Zipkin (HTTP API)[http://zipkin.io/zipkin-api/#/paths/%252Fspans]. The reporter adapts the collectedTraceSpansinto the span format for Zipkin.This was tested against a local Zipkin instance running in docker.