Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Add instrumentation for grpc #343

Merged
merged 17 commits into from
Feb 15, 2019
Merged

Add instrumentation for grpc #343

merged 17 commits into from
Feb 15, 2019

Conversation

vigneshtdev
Copy link
Contributor

@vigneshtdev vigneshtdev commented Feb 13, 2019 •
edited
Loading

Added methods to register the basic gRPC views on both client & server side.Addresses #270

vigneshtdev and others added 13 commits January 17, 2019 20:25
@codecov-io
Copy link

codecov-io commented Feb 13, 2019 •
edited
Loading

Codecov Report

Merging #343 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #343      +/-   ##
==========================================
- Coverage   95.17%   95.14%   -0.03%     
==========================================
  Files         122      122              
  Lines        8472     8472              
  Branches      750      750              
==========================================
- Hits         8063     8061       -2     
- Misses        409      411       +2
Impacted Files Coverage Δ
src/stackdriver-monitoring.ts 81.05% <0%> (-2.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82b26d2...89180d1. Read the comment docs.

mayurkale22
mayurkale22 reviewed Feb 13, 2019
View reviewed changes
packages/opencensus-instrumentation-grpc/src/grpc-stats/stats-common.ts
67108864, 268435456, 1073741824, 4294967296
];
export const DEFAULT_MILLI_SECONDS_DISTRIBUTION: number[] = [
0, 0.01, 0.05, 0.1, 0.3, 0.6, 0.8, 1, 2, 3, 4,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra space between numbers.

mayurkale22
mayurkale22 reviewed Feb 13, 2019
View reviewed changes
Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, added minor nit comments.

@mayurkale22
Copy link
Member

@vigneshtdev friendly ping!

@vigneshtdev
Copy link
Contributor Author

Having to travel too much recently. Will post PR for sure by today

mayurkale22
mayurkale22 reviewed Feb 15, 2019
View reviewed changes
packages/opencensus-instrumentation-grpc/src/grpc-stats/server-metrics.ts Outdated
/**
* {@link View} for server sent messages per RPC.
*
* @since 0.13
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove since

mayurkale22
mayurkale22 reviewed Feb 15, 2019
View reviewed changes
packages/opencensus-instrumentation-grpc/src/grpc-stats/client-metrics.ts Outdated
'Number of response messages received per RPC (always 1 for non-streaming RPCs).');

/**
* {@link Measure} for gRPC client uncompressed response bytes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be " for total bytes received across all response messages per RPC."

mayurkale22
mayurkale22 approved these changes Feb 15, 2019
View reviewed changes
Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added few minor nits

packages/opencensus-instrumentation-grpc/src/grpc-stats/server-metrics.ts Outdated
/**
* {@link View} for server received bytes per RPC.
*
* @since 0.13
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

draffensperger
draffensperger approved these changes Feb 15, 2019
View reviewed changes
packages/opencensus-instrumentation-grpc/src/grpc-stats/stats-common.ts Outdated
import {GRPC_BASIC_CLIENT_VIEWS} from './client-metrics';
import {GRPC_BASIC_SERVER_VIEWS} from './server-metrics';

// Common histogram bucket boundaries for bytes received/sets Views.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: could you make this a JSDoc comment /** */ and same for DEFAULT_MILLI_SECONDS_DISTRIBUTION and DEFAULT_MESSAGE_COUNT_DISTRIBUTION below too?

@mayurkale22
Copy link
Member

There are still few measures (like: grpc.io/client/started_rpcs) and views are pending to add as per specs. I am ok to add those in separate PR. Just wanted to leave a note before we merge this.

@vigneshtdev
Copy link
Contributor Author

Yeah sure, will add the extra ones in a separate PR.

@mayurkale22 mayurkale22 merged commit 3638ca5 into census-instrumentation:master Feb 15, 2019
@mayurkale22 mayurkale22 mentioned this pull request Apr 3, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mayurkale22 mayurkale22 mayurkale22 approved these changes

@draffensperger draffensperger draffensperger approved these changes

Assignees
No one assigned
Labels
cla: yes GA-Effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vigneshtdev @codecov-io @mayurkale22 @draffensperger @googlebot @songy23