Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Pin mongodb dependency #309

Merged
merged 1 commit into from
Jan 25, 2019

Conversation

mayurkale22
Copy link
Member

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #309 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #309      +/-   ##
==========================================
+ Coverage   94.72%   94.75%   +0.02%     
==========================================
  Files         114      114              
  Lines        7603     7603              
  Branches      692      692              
==========================================
+ Hits         7202     7204       +2     
+ Misses        401      399       -2
Impacted Files Coverage Δ
test/test-http2.ts 98.66% <0%> (+1.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e3d5aa...81fcd8f. Read the comment docs.

@mayurkale22
Copy link
Member Author

Node 6 build started failing ever since mongodb published new version 3.1.11 (10 days before). The error was -> no original function _find to wrap, looks like they have deprecated _find_ cursor method from mongodb-core (3.1.10) which comes with mongodb >= 3.1.11. For now, I have pinned mongodb dependency to previous stable version (3.1.10).

I think next action item should be to replace _find cursor method with next and fix the test cases accordingly.

@mayurkale22 mayurkale22 merged commit de34faf into census-instrumentation:master Jan 25, 2019
@mayurkale22 mayurkale22 deleted the build_fix branch January 25, 2019 20:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants