This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Remove mocha type reference in @opencensus/core
release code
#254
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated code in
build/src/trace/model/tracer.d.ts
andbuild/src/trace/model/types.d.ts
includes a line/// <reference types="mocha" />
. I believe that's because TypeScript sees that theNodeJS.EventEmitter
type is not defined in the file and so it pulls in the included global types, including the Mocha types. That means that when@opencensus/core
is imported into another TypeScript NPM module, it needs to bring in the@types/mocha
package in order to compile.This fixes that by separating out the test and release compilation steps and having two separate tsconfig files with different
types
definitions. As a side benefit, this also means thatnpm run prepare
will fail if any code in thesrc
folder accidentally references any Mocha types.