This repository has been archived by the owner on Dec 23, 2023. It is now read-only.
Stats/Prometheus: export data using metrics API #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1509 +/- ##
============================================
+ Coverage 82.6% 82.63% +0.03%
- Complexity 1648 1661 +13
============================================
Files 251 251
Lines 7782 7803 +21
Branches 743 755 +12
============================================
+ Hits 6428 6448 +20
+ Misses 1129 1128 -1
- Partials 225 227 +2
Continue to review full report at Codecov.
|
songy23
reviewed
Oct 22, 2018
| * Type#GAUGE} and {@link Distribution} will be {@link Type#HISTOGRAM}. Please note we cannot set | ||
| * bucket boundaries for custom {@link Type#HISTOGRAM}. | ||
| * <p>Each OpenCensus {@link Metric} will be converted to a Prometheus {@link MetricFamilySamples}, | ||
| * and each {@code Row} of the {@link Metric} will be converted to Prometheus {@link Sample}s. |
.../prometheus/src/main/java/io/opencensus/exporter/stats/prometheus/PrometheusExportUtils.java
Show resolved
Hide resolved
songy23
reviewed
Oct 22, 2018
.../prometheus/src/main/java/io/opencensus/exporter/stats/prometheus/PrometheusExportUtils.java
Show resolved
Hide resolved
.../prometheus/src/main/java/io/opencensus/exporter/stats/prometheus/PrometheusExportUtils.java
Show resolved
Hide resolved
bogdandrutu
approved these changes
Oct 25, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #1483