This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Allow views on measurements without required tags to succeed #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanbrandhorst
commented
Nov 28, 2018
|
|
||
| want := `# HELP tests_foo foo | ||
| # TYPE tests_foo counter | ||
| tests_foo{key=""} 1 |
There was a problem hiding this comment.
This is assuming that we would just create an empty value label for missing tags.
|
Label this as |
|
Working on a fix. |
|
Fixed in #989 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #659. So far this just adds a failing test, but I intend to submit a fix for this once the correct behaviour has been decided.