This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Allow replacing trace SDK; attempt 2 #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
force-pushed
the
replace_sdk_v2
branch
from
5bf9865
to
f27f9c8
Compare
nilebox
reviewed
Oct 28, 2020
nilebox
approved these changes
Oct 28, 2020
nilebox
reviewed
Oct 28, 2020
dashpole
force-pushed
the
replace_sdk_v2
branch
from
f27f9c8
to
027ec7c
Compare
nilebox
approved these changes
Oct 28, 2020
|
This should be good to go. |
This was referenced Mar 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt at #1234.
This time, it is completely backwards-compatible--including with the handling of nil
*Spans.To accomplish this, we introduce a new
Spanstruct, which wraps aSpanInterfaceimplementation provided by the tracer.@nilebox