Trace exporter implemetation #1
Conversation
| rescue StandardError => err | ||
| warn "Unable to export to OCAgent service: #{err.class} #{err}" | ||
| ensure | ||
| Thread.pass |
There was a problem hiding this comment.
I have added rescue block just for logging purpose, issues like not able to established connection to agent service
There was a problem hiding this comment.
ensure block to pass immediate execution if other threads running in process.
|
|
||
| # Run exporter stream. | ||
| def background_export_run | ||
| client.export(@trace_req_queue.each_item).each {} |
There was a problem hiding this comment.
Why do you need to call .each{} on the result?
There was a problem hiding this comment.
export is bidirectional grpc call which need to be kept alive for the entire life of process and export returning Enumerator instance with empty objects.
| # Stop the trace export stream. | ||
| def stop | ||
| @stopped = true | ||
| @trace_req_queue&.push TraceEnumeratorQueue::SENTINEL |
There was a problem hiding this comment.
What happens when background_export_run reaches the sentinel?
There was a problem hiding this comment.
When it reached the sentinel, it will break the export grpc bidirectional call and export thread execution will complete
No description provided.