Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Fix k8s_container resource labels. #93

Merged
merged 3 commits into from
Feb 28, 2019
Merged

Fix k8s_container resource labels. #93

merged 3 commits into from
Feb 28, 2019

Conversation

songy23
Copy link
Contributor

@songy23 songy23 commented Feb 28, 2019

Fixes #92.

@songy23 songy23 added the bug Something isn't working label Feb 28, 2019
@songy23 songy23 requested a review from rghetia February 28, 2019 17:22
rghetia
rghetia approved these changes Feb 28, 2019
View reviewed changes
Copy link
Contributor

@rghetia rghetia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songy23 songy23 merged commit aaad73f into census-ecosystem:master Feb 28, 2019
@songy23 songy23 deleted the fix-k8s-container branch February 28, 2019 17:45
@DanTulovsky
Copy link

I think you missed one more:

2019/03/01 15:33:04 Failed to export to Stackdriver: rpc error: code = InvalidArgument desc = One or more TimeSeries could not be written: Unrecognized resource label: instance_id: timeSeries[0-9]

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rghetia rghetia rghetia approved these changes

Assignees
No one assigned
Labels
bug Something isn't working cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@songy23 @DanTulovsky @rghetia @googlebot