Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

go.mod: update dependencies and tidy up #88

Merged
merged 1 commit into from
Feb 26, 2019
Merged

go.mod: update dependencies and tidy up #88

merged 1 commit into from
Feb 26, 2019

Conversation

fsouza
Copy link
Contributor

@fsouza fsouza commented Feb 26, 2019

This is the result of updating aws-sdk-go and running go mod tidy. A lot
has happened since go modules where introduced in this repo, so go mod
tidy refreshes a lot of things.

The motivation is that we use this as a library in gizmo and we want to make sure our deps are fresh :)

This is the result of updating aws-sdk-go and running go mod tidy. A lot
has happened since go modules where introduced in this repo, so go mod
tidy refreshes a lot of things.
Copy link
Contributor

@odeke-em odeke-em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you @fsouza for this tidying up #punUnintended
and great to hear that you and your team at New York Times are using OpenCensus.

LGTM, but I have some suggestions:
a) Have you taken a look at the new OpenCensus Agent https://opencensus.io/agent/?
With the agent, you'll no longer have to add each exporter in your code. You'll just need to enable the
ocagent-go-exporter and then running your agent out of process configure the agent to export to a variety of backends https://opencensus.io/agent/exporters/
b) If you and your team are comfortable publicly declaring yourselves OpenCensus users, would you mind sending a PR to https://github.com/census-instrumentation/opencensus-website adding yourselves as users to https://opencensus.io/community/users/
If you'd like me to do so, and y'all provide the approval I'd be delighted to do so :)

@odeke-em
Copy link
Contributor

@songy23 @rghetia let's also publish a minor release so that folks can have these cleaned up dependencies.

@odeke-em odeke-em merged commit 91f15dd into census-ecosystem:master Feb 26, 2019
@rghetia
Copy link
Contributor

rghetia commented Feb 26, 2019

sure.

@fsouza fsouza deleted the go-mod-refresh branch February 26, 2019 22:21
@fsouza
Copy link
Contributor Author

fsouza commented Feb 26, 2019

Hey @odeke-em, I wasn't aware of the agent, I'll share with folks internally and see if there's interest. I suppose we may want to keep it as is, so we don't have to run the agent 😁 (even if we do it as a side-car, it's still one more thing to run).

Regarding putting the NYT logo in the users section, that can be tricky :(((

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants