Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Enable test coverage. #200

Merged
merged 8 commits into from
Sep 5, 2019
Merged

Conversation

bogdandrutu
Copy link
Contributor

No description provided.

Copy link
Contributor

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scripts/check-test-files.sh: 4: set: Illegal option -o pipefail
Makefile:28: recipe for target 'test-with-cover' failed
make: *** [test-with-cover] Error 2
The command "make travis-ci" exited with 2.

Please fix.

@bogdandrutu
Copy link
Contributor Author

@songy23 don't know exactly how. I need to read more details.

@bogdandrutu
Copy link
Contributor Author

@songy23 for the moment I enabled coverage without the script to check that we don't have empty packages (no tests). I will do that later, but this PR got bigger and a lot of improvements will be blocked.

@codecov-io
Copy link

codecov-io commented Sep 5, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@dd3a274). Click here to learn what that means.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #200   +/-   ##
========================================
  Coverage          ?   71.3%           
========================================
  Files             ?      15           
  Lines             ?    1582           
  Branches          ?       0           
========================================
  Hits              ?    1128           
  Misses            ?     374           
  Partials          ?      80
Impacted Files Coverage Δ
monitoredresource/gcp_metadata_config.go 0% <ø> (ø)
resource.go 100% <ø> (ø)
trace.go 59.09% <0%> (ø)
monitoredresource/aws_identity_doc_utils.go 0% <0%> (ø)
stackdriver.go 30.92% <100%> (ø)
stats.go 77.35% <100%> (ø)
metrics_proto.go 84.08% <50%> (ø)
metrics_batcher.go 51.42% <66.66%> (ø)
metrics.go 80.37% <75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd3a274...357a4c8. Read the comment docs.

Copy link
Contributor

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after adding internal/tools.go.

@bogdandrutu bogdandrutu merged commit b5c7a2c into census-ecosystem:master Sep 5, 2019
@bogdandrutu bogdandrutu deleted the cover branch September 5, 2019 17:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants