-
Notifications
You must be signed in to change notification settings - Fork 79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scripts/check-test-files.sh: 4: set: Illegal option -o pipefail
Makefile:28: recipe for target 'test-with-cover' failed
make: *** [test-with-cover] Error 2
The command "make travis-ci" exited with 2.
Please fix.
@songy23 don't know exactly how. I need to read more details. |
@songy23 for the moment I enabled coverage without the script to check that we don't have empty packages (no tests). I will do that later, but this PR got bigger and a lot of improvements will be blocked. |
Codecov Report
@@ Coverage Diff @@
## master #200 +/- ##
========================================
Coverage ? 71.3%
========================================
Files ? 15
Lines ? 1582
Branches ? 0
========================================
Hits ? 1128
Misses ? 374
Partials ? 80
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add an internal/tools.go
, similar to https://github.com/open-telemetry/opentelemetry-service/blob/master/internal/tools.go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after adding internal/tools.go
.
No description provided.