Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Reproduce bug in stackdriver exporter. #199

Merged
merged 4 commits into from
Sep 5, 2019

Conversation

bogdandrutu
Copy link
Contributor

No description provided.

Copy link
Contributor

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the build. You may update https://github.com/census-ecosystem/opencensus-go-exporter-stackdriver/blob/master/metrics_test_utils.go#L45 to ignore the unwanted fields in timestamp pb.

equivalence_test.go Show resolved Hide resolved
@songy23 songy23 requested a review from rghetia September 5, 2019 17:11
@codecov-io
Copy link

Codecov Report

Merging #199 into master will increase coverage by 0.62%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
+ Coverage    71.3%   71.92%   +0.62%     
==========================================
  Files          15       15              
  Lines        1582     1585       +3     
==========================================
+ Hits         1128     1140      +12     
+ Misses        374      365       -9     
  Partials       80       80
Impacted Files Coverage Δ
metrics_test_utils.go 78.94% <42.85%> (-8.56%) ⬇️
metrics_proto.go 85.88% <0%> (+1.8%) ⬆️
stackdriver.go 36.08% <0%> (+5.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5c7a2c...5127e72. Read the comment docs.

@songy23 songy23 merged commit 2fdcf7b into census-ecosystem:master Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants