This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Cache seen resources for each export request #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
reviewed
Aug 28, 2019
stats.go
Outdated
| @@ -106,6 +108,7 @@ func newStatsExporter(o Options) (*statsExporter, error) { | |||
| createdViews: make(map[string]*metricpb.MetricDescriptor), | |||
| protoMetricDescriptors: make(map[string]*metricpb.MetricDescriptor), | |||
| metricDescriptors: make(map[string]*metricpb.MetricDescriptor), | |||
| seenResources: make(map[*resourcepb.Resource]*monitoredrespb.MonitoredResource), | |||
There was a problem hiding this comment.
To avoid extra memory usage, can we cache this for every export request. Every export request presumably will have >20 timeseries so we don't get as much win as we would get with this change, but at least we do not OOM.
There was a problem hiding this comment.
Make sense to me, updated in 8800548.
This may not be true for the agent/collector. May get up to millions of resource. |
songy23
changed the title
bogdandrutu
approved these changes
Aug 28, 2019
| @@ -299,7 +308,8 @@ func (se *statsExporter) uploadMetricsProto(payloads []*metricProtoPayload) erro | |||
|
|
|||
| var allTimeSeries []*monitoringpb.TimeSeries | |||
There was a problem hiding this comment.
Can we call into ExportMetricsProtoSync from this point? Maybe in a different PR.
rghetia
reviewed
Aug 28, 2019
rghetia
approved these changes
Aug 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid transforming the resource proto over and over again.
There should be a fairly small amount of unique resources so caching shouldn't be a big problem for memory usage.