Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Don't use a timeout context when creating the metrics client. #166

Merged
merged 1 commit into from
Jul 2, 2019

Conversation

ascherkus
Copy link
Contributor

This would prematurely cancel the context used for dialling the gRPC service since grpc.DialContext() is non-blocking. The result was confusing "Unauthenticated" error messages when attempting to upload metrics.

Instead, make the client connection in newStatsExporter() the same as newTraceExporter() where a simple background context is used when creating the client. Change was originally introduced in #58.

Fixes #61.

This would prematurely cancel the context used for dialing the gRPC
service since grpc.DialContext() is non-blocking. The result was
confusing "Unauthenticated" error messages when attempting to upload
metrics.

Fixes census-ecosystem#61.
@songy23 songy23 requested a review from rghetia July 2, 2019 21:01
@rghetia rghetia merged commit e19adcf into census-ecosystem:master Jul 2, 2019
@ascherkus ascherkus deleted the fix-stats-ctx branch October 31, 2019 15:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

on stats, i always have an Unauthenticated error
4 participants