Batch time series with different label values into same request. #119
Conversation
There was a problem hiding this comment.
Awesome, thank you @rghetia! LGTM with some suggestions but also it would be great to file
a bug describing the problem and also what the fix is. This will massively help in bug diagnosis
and regression analysis to figure out why we added this code; just like you saw how we debugged
and came up with the solution. Once you have opened the bug, please refer to it in the comments
here and also reference it in the commit message.
metrics_proto.go
Outdated
| @@ -39,6 +39,8 @@ import ( | |||
| commonpb "github.com/census-instrumentation/opencensus-proto/gen-go/agent/common/v1" | |||
| metricspb "github.com/census-instrumentation/opencensus-proto/gen-go/metrics/v1" | |||
| resourcepb "github.com/census-instrumentation/opencensus-proto/gen-go/resource/v1" | |||
| "sort" | |||
There was a problem hiding this comment.
Please put these imports in the same section as the standard library imports.
i.e.
import (
"context"
"errors"
"fmt"
"path"
"sort"
"strings"
metrics_proto.go
Outdated
| @@ -117,6 +119,17 @@ func (se *statsExporter) handleMetricsProtoUpload(payloads []*metricProtoPayload | |||
| return nil | |||
| } | |||
|
|
|||
| func signature(metric *googlemetricpb.Metric) string { | |||
There was a problem hiding this comment.
Perhaps let's add a comment here and also rename this function:
// metricSignature creates a unique signature consisting of a
// metric's type and its lexicographically sorted label values
func metricSignature(metric *googlemetricpb.Metric) string {
| @@ -117,6 +119,19 @@ func (se *statsExporter) handleMetricsProtoUpload(payloads []*metricProtoPayload | |||
| return nil | |||
| } | |||
|
|
|||
| // metricSignature creates a unique signature consisting of a | |||
| // metric's type and its lexicographically sorted label values | |||
There was a problem hiding this comment.
Just one last comment request. Since you've created the issue, please add it here to finally make this comment:
// metricSignature creates a unique signature consisting of a
// metric's type and its lexicographically sorted label values.
// See https://github.com/census-ecosystem/opencensus-go-exporter-stackdriver/issues/120
func metricSignature(metric *googlemetricpb.Metric) string {
fixes #120