Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TPHD] Add bloom graphic pack #642

Merged
merged 12 commits into from
Oct 15, 2024
Merged

Conversation

KoB-Kirito
Copy link
Contributor

@KoB-Kirito KoB-Kirito commented Sep 14, 2024

Inspired by the work of @skalfate - #508 (comment)

I tinkered a lot with the values, tested them in different areas of the game and condensed them in useful presets.
Changing the bloom improves this game so much, it should be available to everyone!

Changes the bloom in the game, which is used aggressively in the shadow world, where it has a strong yellow cast. Can also remove the yellow tint by shifting the bloom color to blue. A too high value can cause a blue cast outside of the shadow world. Up to 50% is safe.

Here a comparison.
Native bloom:
bloom native

50% bloom, 50% blue shift:
bloom 50 blue shift 50

Bloom disabled:
bloom disabled

@KoB-Kirito
Copy link
Contributor Author

KoB-Kirito commented Sep 29, 2024

I found more shaders connected to bloom, dove deep into glsl to understand them and improved this pack a lot!

  • I apply the bloom level to the mask directly now, which results in a more even distribution of bloom when lowered. That also enables levels above 100% again.
  • I found out how the color tint is applied (which is a static color that differs from area to area btw) and interpolate from that to an even luminance. Basically you can choose freely between intended tint and no tint at all safely without blue tint elsewhere now. (Let me know if you need custom color shift back, it didn't feel very helpful though)
  • I found the shaders that color grade the shadow world darker and desaturate it. Not directly bound to bloom, but fits in this pack I think. For most that just find the shadow world too depressing, changing these settings is more useful than the bloom I think.

Here are some screenshots of the new version.
Native:
v2 native

Recommended settings (I liked the most): bloom 50, tint 80, darken 20, desaturate 50:
v2 recommended

And bloom disabled with the color grading removed also (compare to disabled above):
v2 all disabled

I also found some HUD elements missing in the RemoveHUD pack (textbox elements) and added those for screenshots.

The only thing I would like to add still is a setting for the periodic blur of the bloom, but I didn't manage to understand those shaders yet. I guess this could be solved better by ASM, to change the SIN/time var that controls it. If anyone knows that stuff, please help!
I found some get nauseated by the blur and I feel that's the only reason they disable bloom entirely. If you could change this, the bloom could be set higher.

I still think this game is better with bloom. It gives a lot of atmosphere to many places. But I agree that it is overdone a bit and more control over it feels nice.

Copy link
Member

@Crementif Crementif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think both the description and some of the preset names could be a little more concise and cleaned up so that general users better understand the options and the effects of this graphic pack. Other then that, your screenshots seem like they'd help a lot of people!

Enhancements/TwilightPrincessHD_Bloom/rules.txt Outdated Show resolved Hide resolved
Enhancements/TwilightPrincessHD_Bloom/rules.txt Outdated Show resolved Hide resolved
Enhancements/TwilightPrincessHD_Bloom/rules.txt Outdated Show resolved Hide resolved
Enhancements/TwilightPrincessHD_Bloom/rules.txt Outdated Show resolved Hide resolved
Enhancements/TwilightPrincessHD_Bloom/rules.txt Outdated Show resolved Hide resolved
Enhancements/TwilightPrincessHD_Bloom/rules.txt Outdated Show resolved Hide resolved
Enhancements/TwilightPrincessHD_Bloom/rules.txt Outdated Show resolved Hide resolved
Enhancements/TwilightPrincessHD_Bloom/rules.txt Outdated Show resolved Hide resolved
@KoB-Kirito
Copy link
Contributor Author

KoB-Kirito commented Oct 14, 2024

So, I added simple presets and nested the finer options under a custom preset. That actually works very well.
By default you only see this and can select a preset:
grafik
grafik

But when you select custom, you can adjust the individual settings:
grafik

Same for color grading. I also reversed the logic and the name should now make very clear what they do:
grafik
grafik

Also added more to the description.
What do you think?

@KoB-Kirito
Copy link
Contributor Author

Here some saves to test shadow world. It takes an hour to reach it..
2. is first time shadow world (meeting midna), 3. is zanto gets midna cutscene
save.zip

Copy link
Member

@Crementif Crementif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that looks great! Thanks for making the adjustments, looks good to merge. I do have two comments, but they don't have to be addressed.

@Crementif Crementif merged commit 46db482 into cemu-project:master Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants