LwIP consistently hits SIGSEGVs #32
Assignees
Comments
|
Tombstones: |
ignoramous
referenced
this issue
in celzero/outline-go-tun2socks
Aug 16, 2020
A closer look reveals that core.tcpConn.Close isn't doing the desired clean-up; and probably a core.tcpConn.Abort is a better match to firewall a connection cleanly. Calling core.tcpConn.Abort is better left to the downstream caller. Returning a error from registered-tcp-handler does in fact abort the connection as required. Similar change for udp connections too, only that instead of both closing the connection and returning an error, we err on the side of just returning an error. Ocassional SIGSEGVs originating deep in LwIP when firewalling and de-firewalling connections hopefully now is put to bed.
Closed
|
Seeing different errors, but usually on-network-change events (and sometimes on mode changes for ex: dns-only to dns+firewall). |
|
Moar: |
|
Happened during screen off |
|
Get this fix in: eycorsican/go-tun2socks/commit/3898cb0a0. |
ignoramous
added a commit
to celzero/outline-go-tun2socks
that referenced
this issue
Sep 4, 2020
New release contains a fixe for double-free on tcp process-control-block celzero/rethink-app#32
|
When the tunnel is |
hussainmohd-a
added a commit
that referenced
this issue
Sep 7, 2020
Connection Tracking : Network monitor screen performance has been improved. New schema has been introduced to handle the changes. Now user has provision to search by app name and IP address. Filtering of logs based on blocked/all is implemented. Provision to delete the logs from network monitor. Some of the features are yet to be implemented. Bug FIxes: * Samsung Minor bug fix - Introduced the INTERACT_ACROSS_USERS permission for samsung devices. Always-on - prompt is shown now when user taps the 'Start' button. * Background Apps - Universal firewall for allow apps on background logic is changed. Now the uid's which are in range from APP_START to APP_END is included. Now it works as originally intended. #65 * Lwip Fix - A critical stability fix that caused frequent app crashes in the background. #32 * Accessbility Services - On-Interuppt method was not handled properly earlier. #75 * In Firewall screen the warning text for System apps in included. #70 * App crashes when other VPN is in active - Application state is now properly updated so that it can handle the other VPN active scenarios. * Right-to-Left languages - UI changes. The Home screen's 'Start' button and about page UI modifications to support rtl languages. * Firewall crash - app crash when there is change in installed/system packages. Now the app list is refreshed based on the app changes. When a new app in installed/modified/removed the list will be refreshed with the current data. * Auto-start - auto start of application is now been disabled. Will introduce advanced settings on later versions to enable/disable the auto start of app during phone boot updated #41
|
See #79 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At least two crashes in space of 12 hours, both in the LwIP stack of gotun2socks presumably because some
tcpstate has gone whack.I am starting to think that we do not terminate the connection like we normally should (Android's implementation indicates it relies on
PROHIBITresponse from the Kernel to terminate connections). A gentletcpConn.Closemight not be enough and atcpConn.Abortmight be of order.The implementation differences in go-tun2socks for
tcpConn.CloseandtcpConn.Abortdo reveal stark differences, the primary is thatconn.stateisn't updated in the former case whilst it is set totcpAbortingin the latter case.Further more,
tcpConn.Abortis what go-tun2socks uses to rid of connection when there's anyerrreported by theregisteredTCPHandler.Crashes (both happened after firewall was relaxed after a screen-on event):
No. 1
No. 2
See #19 #26
The text was updated successfully, but these errors were encountered: