Add celo-org/op-geth dependencies update script and gh-action
#263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piersy
reviewed
Oct 22, 2024
Update the go package dependency and the devnet
docker container reference of the `l2` service
to the latest commit ('c6d7b55a9a0361d36a36e6cee6a423611e4ddbf8') in the 'celo10' ref.
ezdac
force-pushed
the
ezdac/geth-update-script
branch
from
7ff1ab9
to
9678123
Compare
ezdac
changed the title
celo-org/op-geth dependencies update scriptcelo-org/op-geth dependencies update script and gh-action
ezdac
force-pushed
the
ezdac/geth-update-script
branch
4 times, most recently
from
6878a43
to
4e2acab
Compare
ezdac
commented
Oct 23, 2024
| - name: Login at GCP Artifact Registry | ||
| uses: celo-org/reusable-workflows/.github/actions/[email protected] | ||
| with: | ||
| workload-id-provider: "projects/1094498259535/locations/global/workloadIdentityPools/gh-optimism/providers/github-by-repos" |
There was a problem hiding this comment.
@pputman-clabs could you give the github action GCP auth part a review?
I simply pasted it from another action and I don't know if this is the correct workload-id-provider.
The action requires authentication, although it simply reads some artifact properties from a public repository.
To open PR's, the action also requires some permissions in GitHub (see here). Would it be okay to enable this?
ezdac
force-pushed
the
ezdac/geth-update-script
branch
from
4e2acab
to
1390106
Compare
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #262 for more info.