-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OptimismPortal set initial balance through StorageSetter pattern #250
Conversation
This reverts commit 77babf4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I added some minor questions / suggestions.
It would be good to implement the storage modification for the OptimismPortal2
as well,
so we include fault-proof compatible contracts already before the code-freeze (see #239), but we can also create a follow-up PR.
The OP style-guide mentions to do all the upgrade steps atomically (modify-storage, change implementation, call initialize). We don't do this here, but I think for the initial deployment this is not as important as upgrading existing contracts on a live-network - do you agree?
Since we are owners during the whole process it shouldn't be a problem at all |
#193
Reverts a change to OptimismPortal initialize function originally introduced so we can set initialBalance of OptimismPortal. Instead we now use storage setter in following pattern.