Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commented out MaxInputSize checks #190

Closed
wants to merge 6 commits into from
Closed

Conversation

jcortejoso
Copy link
Member

@jcortejoso jcortejoso commented Jul 3, 2024

// Don't merge it please

carterqw2 and others added 6 commits July 3, 2024 12:39
* Fix migration script gap in migrated blocks

The range of ancient blocks to remove from the non ancients database was
off by one and resulted in a gap between ancients and non ancients.

Also corrected some log statements that were off by one.
...with the FeeCurrency in celo/testing/FeeCurrency.sol . It also is a
good idea to clearly name abstract contracts, so that nobody tries to
use them as a non-abstract contract (e.g. tries a deployment).
Copy link

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jul 19, 2024
@github-actions github-actions bot closed this Jul 24, 2024
@jcortejoso jcortejoso reopened this Jul 25, 2024
@jcortejoso
Copy link
Member Author

This is not yet ready to be merged and need deeper tests and analysis, but we probably need to check in the short future.

@github-actions github-actions bot removed the Stale label Jul 26, 2024
Copy link

github-actions bot commented Aug 9, 2024

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Aug 9, 2024
@github-actions github-actions bot closed this Aug 15, 2024
karlb pushed a commit that referenced this pull request Aug 30, 2024
karlb pushed a commit that referenced this pull request Aug 30, 2024
* Prevent reiniting preimage uploads. (#190)

* fix(ctb): PreimageOracle `loadLocalData` length check

* fixes

* fix: bump preimage oracle semver

* chore: snapshots

* fix: gas snapshot

* revert: gas snapshot changes

---------

Co-authored-by: Adrian Sutton <[email protected]>
Co-authored-by: clabby <[email protected]>
karlb pushed a commit that referenced this pull request Aug 30, 2024
* Prevent reiniting preimage uploads. (#190)

* fix(ctb): Perform correct clock validation in FDG constructor

Fixes the clock extension / max clock duration check in the
`FaultDisputeGame` constructor to account for the worst-case clock
extension.

* fix: add semver-lock

* fix: add kontrol

* gas snapshot

* fix: gas snapshot and semver-lock

---------

Co-authored-by: Adrian Sutton <[email protected]>
Co-authored-by: refcell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants