Add CallProxies for mainnet addresses on alfajores #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pahor167
previously approved these changes
Jun 17, 2024
| returndatacopy(0, 0, returndatasize()) | ||
|
|
||
| switch result | ||
| // delegatecall returns 0 on error. |
There was a problem hiding this comment.
Suggested change
| // delegatecall returns 0 on error. | |
| // call returns 0 on error. |
| implementation = _implementation; | ||
| } | ||
|
|
||
| function _delegate(address _implementation) internal virtual { |
There was a problem hiding this comment.
can we rename it to something like _call since we are not actually delegating?
This is a good workaround |
|
This doesn't work, the approach fails for payable contracts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #141
Moving state accounts including storage turned out to be not supported. As we currently only need this for testnets, this offers an alternative solution instead.
This PR creates a new proxy which used
callto forward calls to the implementation contract. It should only be used for proxying mainnet addresses to the respective (normal) proxy on alfajores.@pahor167 Please give me some early feedback on this approach 🙏