feat: Adding some extra config to config.sh script
#151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Guide I used for deploying from this branch: |
palango
reviewed
Jun 19, 2024
| "daChallengeWindow": 160, | ||
| "daResolveWindow": 160, | ||
| "daBondSize": 1000000, | ||
| "daResolverRefundPercentage": 0 |
There was a problem hiding this comment.
I'm not sure if there's a use case for it, but you could add deployCeloContracts here as well.
palango
approved these changes
Jun 19, 2024
Included Fjord hardfork
Adding deployCeloContracts config
palango
reviewed
Jun 21, 2024
| "gasPriceOracleScalar": 1000000, | ||
|
|
||
| "enableGovernance": true, | ||
| "deployCeloContracts": true, |
There was a problem hiding this comment.
Is this to use together with migrated state? Then it should default to false.
There was a problem hiding this comment.
Good to know, I'll add as a .envrc variable then
palango
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some additional exposure to
config.shscript to expose on.envrcconfigurations that may be interesting to consider when deploying a new testnet.Also included a small fix on Makefile caused by a dead npm script: ethereum-optimism#10821