Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs generation #84

Merged
merged 4 commits into from
Jan 22, 2024
Merged

Fix docs generation #84

merged 4 commits into from
Jan 22, 2024

Conversation

shazarre
Copy link
Contributor

Description

This PR aims at fixing docs generation due to typescript upgrade and typedoc module no longer working in the version that the project was using.

Other changes

Removed linkdocs.ts script as SUMMARY.md file is no longer generated by typedoc markdown plugin due to the update and so it doesn't make any sense to keep it. Removed its usages, script(s) and reference in the docs.

Tested

Tested locally by running the command.

Related issues

Backwards compatibility

It's backwards compatible as no public API is affected.

Documentation

Format of the autogenerated docs is changed due to the updates in the typedoc and corresponding markdown plugin.

Copy link

changeset-bot bot commented Jan 17, 2024

⚠️ No Changeset found

Latest commit: c5e2de9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@shazarre shazarre self-assigned this Jan 17, 2024
Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: [email protected], [email protected]

@shazarre shazarre marked this pull request as ready for review January 18, 2024 09:57
@shazarre shazarre requested a review from a team as a code owner January 18, 2024 09:57
Copy link
Member

@aaronmgdr aaronmgdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i didnt review the md files themselves but the setup seems good

@arthurgousset arthurgousset requested a review from a team January 22, 2024 08:47
@arthurgousset
Copy link
Contributor

I'll take a look at the generated files 👍

@arthurgousset
Copy link
Contributor

arthurgousset commented Jan 22, 2024

Notes-to-self (things out of scope for this PR)

  1. In typedoc.json there is an option "githubPages": false. I expect, it relates to automatically publishing the generated docs to a Github Page. This issue has an interesting discussion section on this topic:
  1. I see that package.json has a docs script
"scripts": {
   
    "docs": "yarn run --top-level typedoc",
    
  },
  • Question: Check if this script is ever run in CI (not necessarily every time), so that docs are automatically updated and don't need to be manually generated/committed.

Copy link
Contributor

@arthurgousset arthurgousset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated docs look good to me

Copy link
Contributor

@arthurgousset arthurgousset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated docs look good to me

@arthurgousset arthurgousset merged commit c467b4e into master Jan 22, 2024
16 checks passed
@arthurgousset arthurgousset deleted the shazarre/fix_typedoc branch January 22, 2024 10:31
@aaronmgdr
Copy link
Member

#8 handles the Run in CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yarn docs command is failing
3 participants