-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docs generation #84
Conversation
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: [email protected], [email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i didnt review the md files themselves but the setup seems good
I'll take a look at the generated files 👍 |
Notes-to-self (things out of scope for this PR)
"scripts": {
"docs": "yarn run --top-level typedoc",
},
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generated docs look good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generated docs look good to me
#8 handles the Run in CI |
Description
This PR aims at fixing docs generation due to typescript upgrade and
typedoc
module no longer working in the version that the project was using.Other changes
Removed
linkdocs.ts
script asSUMMARY.md
file is no longer generated bytypedoc
markdown plugin due to the update and so it doesn't make any sense to keep it. Removed its usages, script(s) and reference in the docs.Tested
Tested locally by running the command.
Related issues
Backwards compatibility
It's backwards compatible as no public API is affected.
Documentation
Format of the autogenerated docs is changed due to the updates in the
typedoc
and corresponding markdown plugin.