Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github actions upload-artfiact to version 4 due to EOL #483

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

pputman-clabs
Copy link
Contributor

@pputman-clabs pputman-clabs commented Dec 10, 2024

Description

Github is setting actions/upload-artifact version 3 to EOL and workflows will fail because of it

Other changes

none

Tested

We've used version 4 in other workflows and haven't had any issues.


PR-Codex overview

This PR updates the GitHub Actions workflow for continuous integration by changing the version of the actions/upload-artifact from v3 to v4.

Detailed summary

  • Updated the actions/upload-artifact from v3 to v4 in the .github/workflows/ci.yml file.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@pputman-clabs pputman-clabs requested a review from a team as a code owner December 10, 2024 22:46
Copy link

changeset-bot bot commented Dec 10, 2024

⚠️ No Changeset found

Latest commit: 39da713

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.44%. Comparing base (913961e) to head (39da713).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #483   +/-   ##
=======================================
  Coverage   73.44%   73.44%           
=======================================
  Files         240      240           
  Lines       10180    10180           
  Branches     1619     1614    -5     
=======================================
  Hits         7477     7477           
+ Misses       2636     2611   -25     
- Partials       67       92   +25     
Components Coverage Δ
celocli 85.23% <ø> (ø)
sdk 68.94% <ø> (ø)
wallets 52.72% <ø> (ø)
viem-sdks 95.08% <ø> (ø)

@aaronmgdr
Copy link
Member

thank you so much @pputman-clabs

@aaronmgdr aaronmgdr merged commit 1007890 into master Dec 11, 2024
27 of 40 checks passed
@aaronmgdr aaronmgdr deleted the pputman/update-actions-upload-artfiact branch December 11, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants